Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-92584: test_cppext uses setuptools #92639

Merged
merged 1 commit into from
May 12, 2022
Merged

gh-92584: test_cppext uses setuptools #92639

merged 1 commit into from
May 12, 2022

Conversation

vstinner
Copy link
Member

Rewrite test_cppext to run in a virtual environment and to build the
C++ extension with setuptools rather than distutils.

Rewrite test_cppext to run in a virtual environment and to build the
C++ extension with setuptools rather than distutils.
@vstinner
Copy link
Member Author

If this approach works and is accepted, we can use the same for test_peg_generator.

@FFY00
Copy link
Member

FFY00 commented May 11, 2022

What happens if CPython for some reason breaks setuptools?

@vstinner
Copy link
Member Author

What happens if CPython for some reason breaks setuptools?

The test fails which is a good thing :-)

@vstinner vstinner merged commit 4e28377 into python:main May 12, 2022
@vstinner vstinner deleted the test_cppext_setuptools branch May 12, 2022 22:20
@vstinner
Copy link
Member Author

Let's try and see how it goes :-)

@vstinner
Copy link
Member Author

Let's try and see how it goes :-)

It fails when _ctypes is not available: #92820

@FFY00: An example of failing setuptools :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants