Skip to content

Fixed a handful of typos #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2017
Merged

Fixed a handful of typos #343

merged 2 commits into from
Mar 1, 2017

Conversation

@alex
Copy link
Member

@alex alex commented Feb 27, 2017

No description provided.

berkerpeksag
berkerpeksag reviewed Feb 27, 2017
View reviewed changes
Doc/library/ssl.rst Outdated

Usually, :class:`SSLSocket` are not created directly, but using the
the :meth:`SSLContext.wrap_socket` method.
Usually, :class:`SSLSocket` are not created directly, but using the :meth:`SSLContext.wrap_socket` method.
Copy link
Member

@berkerpeksag berkerpeksag Feb 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is a bit long. It would be nice to wrap it at 80 or so chars.

Copy link
Member Author

@alex alex Feb 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

marco-buttu
marco-buttu approved these changes Feb 27, 2017
View reviewed changes
Copy link
Contributor

@marco-buttu marco-buttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM :-)

@Mariatta
Copy link
Member

Mariatta commented Feb 27, 2017

So I'm not sure how to apply the labels here lol

Doc/library/email.compat32-message.rst -> needs backport to 3.6
Doc/library/email.message.rst -> needs backport to 3.6
Doc/library/idle.rst -> needs backport to 2.7, 3.5, 3.6
Doc/library/ssl.rst -> needs backport to 3.6

@berkerpeksag
Copy link
Member

berkerpeksag commented Feb 27, 2017

I'd say don't bother to backport this to 2.7 and 3.5 :)

@Mariatta
Copy link
Member

Mariatta commented Feb 27, 2017

ok. then everything else LGTM :)

@Mariatta Mariatta added the docs Documentation in the Doc dir label Feb 27, 2017
@Mariatta Mariatta merged commit 1cf2a80 into python:master Mar 1, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Mar 1, 2017
@alex @Mariatta
Fixed a handful of typos (pythonGH-343)
5272f73 
(cherry picked from commit 1cf2a80)
@alex alex deleted the typos branch March 1, 2017 03:31
Mariatta added a commit that referenced this pull request Mar 1, 2017
@Mariatta
Fixed a handful of typos (GH-343) (GH-364)
1b93ed4 
(cherry picked from commit 1cf2a80)
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@Mariatta
Revert to celery 4.4.2 (#343)
4e89023 
Fix #342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

@Mariatta Mariatta Mariatta approved these changes

+1 more reviewer

@marco-buttu marco-buttu marco-buttu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alex @Mariatta @berkerpeksag @marco-buttu @the-knights-who-say-ni