-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-26175: Fix SpooledTemporaryFile IOBase abstract #3249
bpo-26175: Fix SpooledTemporaryFile IOBase abstract #3249
Commits on Aug 30, 2017
-
Fix SpooledTemporaryFile IOBase abstract
One would assume that this class implements the IOBase abstract. As the underlying file-like object is either io.BytesIO, io.StringIO, or a true file object, this is a reasonable abstract expect and to implement. Regardless, the behaviour of this class does not change much in the case of the attribute being missing from the underlying file-like; an AttributeError is still raised, albeit from one additional frame on the stack trace.
Configuration menu - View commit details
-
Copy full SHA for 83d6152 - Browse repository at this point
Copy the full SHA 83d6152View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b69baa - Browse repository at this point
Copy the full SHA 3b69baaView commit details
Commits on Sep 20, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 753b4fb - Browse repository at this point
Copy the full SHA 753b4fbView commit details
Commits on Sep 30, 2017
-
Configuration menu - View commit details
-
Copy full SHA for a70113e - Browse repository at this point
Copy the full SHA a70113eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb28362 - Browse repository at this point
Copy the full SHA fb28362View commit details
Commits on Sep 9, 2018
-
Return new absolute position from underlying file on seek
Part of file interface: https://docs.python.org/library/io.html#io.IOBase.seek
Configuration menu - View commit details
-
Copy full SHA for bc9d0a9 - Browse repository at this point
Copy the full SHA bc9d0a9View commit details -
We don't want to delete the underlying file explicitly as the expected behaviour is for the file to be deleted *after* it falls out of scope.
Configuration menu - View commit details
-
Copy full SHA for b588dec - Browse repository at this point
Copy the full SHA b588decView commit details -
Return new file size from underlying file on truncate
Part of file interface: https://docs.python.org/library/io.html#io.IOBase.truncate
Configuration menu - View commit details
-
Copy full SHA for ab49dd1 - Browse repository at this point
Copy the full SHA ab49dd1View commit details
Commits on Oct 30, 2019
-
Merge remote-tracking branch 'origin/master' into bpo-26175_fix-Spool…
…edTemporaryFile-IOBase
Configuration menu - View commit details
-
Copy full SHA for 4251b21 - Browse repository at this point
Copy the full SHA 4251b21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19f4c08 - Browse repository at this point
Copy the full SHA 19f4c08View commit details -
Use :class: instead of :py:data:
Co-Authored-By: Éric Araujo <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4519b9c - Browse repository at this point
Copy the full SHA 4519b9cView commit details
Commits on Nov 23, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 554aad6 - Browse repository at this point
Copy the full SHA 554aad6View commit details -
Add test for rolled file finalisation
The underlying file should be deleted when the SpooledTemporaryFile object is deleted. This follows the same behaviour as TemporaryFile and is consistent with the documentation. `__del__` should have the same consequences as using `del` or allowing the object to fall out of scope; an expectation which b588dec (reverted) broke somewhat.
Configuration menu - View commit details
-
Copy full SHA for be094b3 - Browse repository at this point
Copy the full SHA be094b3View commit details