Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-26175: Fix SpooledTemporaryFile IOBase abstract #3249

Closed

Commits on Aug 30, 2017

  1. Fix SpooledTemporaryFile IOBase abstract

    One would assume that this class implements the IOBase abstract. As the
    underlying file-like object is either io.BytesIO, io.StringIO, or a true
    file object, this is a reasonable abstract expect and to implement.
    
    Regardless, the behaviour of this class does not change much in the case
    of the attribute being missing from the underlying file-like; an
    AttributeError is still raised, albeit from one additional frame on the
    stack trace.
    GFernie committed Aug 30, 2017
    Configuration menu
    Copy the full SHA
    83d6152 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3b69baa View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2017

  1. Configuration menu
    Copy the full SHA
    753b4fb View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2017

  1. Configuration menu
    Copy the full SHA
    a70113e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fb28362 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2018

  1. Configuration menu
    Copy the full SHA
    bc9d0a9 View commit details
    Browse the repository at this point in the history
  2. Do nothing on __del__

    We don't want to delete the underlying file explicitly as the expected
    behaviour is for the file to be deleted *after* it falls out of scope.
    GFernie committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    b588dec View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ab49dd1 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2019

  1. Merge remote-tracking branch 'origin/master' into bpo-26175_fix-Spool…

    …edTemporaryFile-IOBase
    GFernie committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    4251b21 View commit details
    Browse the repository at this point in the history
  2. Add versionchanged tag

    GFernie committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    19f4c08 View commit details
    Browse the repository at this point in the history
  3. Use :class: instead of :py:data:

    Co-Authored-By: Éric Araujo <[email protected]>
    GFernie and merwok authored Oct 30, 2019
    Configuration menu
    Copy the full SHA
    4519b9c View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2019

  1. Revert "Do nothing on __del__"

    This reverts commit b588dec.
    GFernie committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    554aad6 View commit details
    Browse the repository at this point in the history
  2. Add test for rolled file finalisation

    The underlying file should be deleted when the SpooledTemporaryFile
    object is deleted. This follows the same behaviour as TemporaryFile and
    is consistent with the documentation. `__del__` should have the same
    consequences as using `del` or allowing the object to fall out of scope;
    an expectation which b588dec (reverted) broke somewhat.
    GFernie committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    be094b3 View commit details
    Browse the repository at this point in the history