Skip to content

bpo-46765: Replace Locally Cached Strings with Statically Initialized Objects #31366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 19 commits into from
Feb 23, 2022
Merged

bpo-46765: Replace Locally Cached Strings with Statically Initialized Objects #31366

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
fdf87ee
Use _Py_ID() in boolobject.c.
ericsnowcurrently Feb 16, 2022
2c2f917
Use _Py_ID() in classobject.c.
ericsnowcurrently Feb 16, 2022
5f2746b
Use _Py_ID() in codeobject.c.
ericsnowcurrently Feb 16, 2022
1df92a0
Drop outdated entries.
ericsnowcurrently Feb 16, 2022
da9810b
Move an entry to the right section.
ericsnowcurrently Feb 16, 2022
b06e610
Drop an outdated entry.
ericsnowcurrently Feb 16, 2022
b8ea691
Use _Py_ID() in listobject.c.
ericsnowcurrently Feb 16, 2022
42b714f
Use _Py_ID() in _warnings.c.
ericsnowcurrently Feb 16, 2022
c7c8faf
Use _Py_ID() in ast_unparse.c.
ericsnowcurrently Feb 16, 2022
92b0069
Use _Py_ID() in compile.c.
ericsnowcurrently Feb 16, 2022
226671e
Use _Py_ID() in symtable.c.
ericsnowcurrently Feb 16, 2022
3acf264
Drop outdated entries.
ericsnowcurrently Feb 16, 2022
3a02502
Use _Py_ID() in sysmodule.c.
ericsnowcurrently Feb 16, 2022
cd47553
Use _Py_ID() in the _io module.
ericsnowcurrently Feb 16, 2022
f8b7071
Use _Py_ID() in _tracemalloc.c.
ericsnowcurrently Feb 16, 2022
76d2955
Drop an outdated entry.
ericsnowcurrently Feb 16, 2022
02995b0
Use b'', not ''.
ericsnowcurrently Feb 16, 2022
efe208f
Use a ternary expression.
ericsnowcurrently Feb 16, 2022
1852340
Merge branch 'main' into global-objects-use-pyid
ericsnowcurrently Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Include/internal/pycore_global_strings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,10 @@ struct _Py_global_strings {
} literals;

struct {
STRUCT_FOR_ID(False)
STRUCT_FOR_ID(Py_Repr)
STRUCT_FOR_ID(TextIOWrapper)
STRUCT_FOR_ID(True)
STRUCT_FOR_ID(WarningMessage)
STRUCT_FOR_ID(_)
STRUCT_FOR_ID(__IOBase_closed)
Expand Down
2 changes: 2 additions & 0 deletions Include/internal/pycore_runtime_init.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,8 +659,10 @@ extern "C" {
INIT_STR(percent, "%"), \
}, \
.identifiers = { \
INIT_ID(False), \
INIT_ID(Py_Repr), \
INIT_ID(TextIOWrapper), \
INIT_ID(True), \
INIT_ID(WarningMessage), \
INIT_ID(_), \
INIT_ID(__IOBase_closed), \
Expand Down
20 changes: 7 additions & 13 deletions Objects/boolobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,20 @@
/* Boolean type, a subtype of int */

#include "Python.h"
#include "pycore_runtime.h" // _Py_ID()
#include "pycore_pyerrors.h" // _Py_FatalRefcountError()

/* We define bool_repr to return "False" or "True" */

static PyObject *false_str = NULL;
static PyObject *true_str = NULL;

static PyObject *
bool_repr(PyObject *self)
{
PyObject *s;

if (self == Py_True)
s = true_str ? true_str :
(true_str = PyUnicode_InternFromString("True"));
else
s = false_str ? false_str :
(false_str = PyUnicode_InternFromString("False"));
Py_XINCREF(s);
return s;
if (self == Py_True) {
return &_Py_ID(True);
}
else {
return &_Py_ID(False);
}
}

/* Function to return a bool from a C long */
Expand Down
2 changes: 0 additions & 2 deletions Tools/c-analyzer/cpython/globals-to-fix.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,8 +280,6 @@ Objects/sliceobject.c - _Py_EllipsisObject -
# cached - initialized once

# manually cached PyUnicodeObject
Objects/boolobject.c - false_str -
Objects/boolobject.c - true_str -
Objects/classobject.c method_get_doc docstr -
Objects/classobject.c instancemethod_get_doc docstr -
Objects/codeobject.c PyCode_NewEmpty emptystring -
Expand Down