-
-
Notifications
You must be signed in to change notification settings - Fork 34.6k
bpo-43869: Time Epoch is the same on all platforms #30664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -159,6 +159,13 @@ def test_sleep(self): | |
| self.assertRaises(ValueError, time.sleep, -1) | ||
| time.sleep(1.2) | ||
|
|
||
| def test_epoch(self): | ||
| # bpo-43869: Make sure that Python use the same Epoch on all platforms: | ||
| # January 1, 1970, 00:00:00 (UTC). | ||
| epoch = time.gmtime(0) | ||
| # Only test the date and time, ignore other gmtime() members | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could test more members, but I don't think that it is worth it. It can make the test more fragile if the exact value changes depending on the platform. |
||
| self.assertEqual(tuple(epoch)[:6], (1970, 1, 1, 0, 0, 0), epoch) | ||
|
|
||
| def test_strftime(self): | ||
| tt = time.gmtime(self.t) | ||
| for directive in ('a', 'A', 'b', 'B', 'c', 'd', 'H', 'I', | ||
|
|
||
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Library/2022-01-18-17-24-21.bpo-43869.NayN12.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Python uses the same time Epoch on all platforms. Add an explicit unit test | ||
| to ensure that it's the case. Patch by Victor Stinner. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads a bit strange now - you tell us exactly what the epoch is, and then tell us how to find out what it is. How about changing the above 3 lines to something like:
epochis the point where the time starts, thereturn value of
time.gmtime(0).It is January 1, 1970, 00:00:00 (UTC) on all platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the doc sounds strange. But I wanted to keep "gmtime(0)", it sounds important to me. I like your wording, I copied it in my PR ;-) Would you mind to review it again?