Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43234: Prohibit non-ThreadPoolExecutor in loop.set_default_executor #24540

Merged
merged 6 commits into from
Jul 1, 2021
Merged

bpo-43234: Prohibit non-ThreadPoolExecutor in loop.set_default_executor #24540

merged 6 commits into from
Jul 1, 2021

Conversation

illia-v
Copy link
Contributor

@illia-v illia-v commented Feb 15, 2021 •
edited by bedevere-bot
Loading

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 18, 2021
serhiy-storchaka
serhiy-storchaka requested changes Jun 28, 2021
View reviewed changes
Doc/library/asyncio-eventloop.rst Outdated Show resolved Hide resolved
Doc/library/asyncio-eventloop.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
Lib/asyncio/base_events.py Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@serhiy-storchaka serhiy-storchaka removed the stale Stale PR or inactive for long period of time. label Jun 28, 2021
@illia-v
Copy link
Contributor Author

illia-v commented Jun 29, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

@illia-v
Copy link
Contributor Author

illia-v commented Jun 29, 2021

@serhiy-storchaka if you have a chance, please take a look at #24525 too

@illia-v @serhiy-storchaka
Update a related test
d5934a0 
Co-authored-by: Serhiy Storchaka <[email protected]>
@illia-v
Copy link
Contributor Author

illia-v commented Jun 30, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

serhiy-storchaka
serhiy-storchaka approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka merged commit ddd5f36 into python:main Jul 1, 2021
eirrgang added a commit to eirrgang/cpython that referenced this pull request Jun 9, 2023
@eirrgang
Remove references to ProcessPoolExecutor from asyncio-dev.rst
0b3e1b6 
ddd5f36 updated asyncio-eventloop.rst, but overlooked other references to using non-ThreadPoolExecutors with `run_in_executor()`.

Ref bpo-43234: Prohibit non-ThreadPoolExecutor in loop.set_default_executor (pythonGH-24540)
@eirrgang eirrgang mentioned this pull request Jun 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@illia-v @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni