Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-27794: Add name attribute to property class #23967

Merged
merged 8 commits into from
Dec 30, 2020
Merged

bpo-27794: Add name attribute to property class #23967

merged 8 commits into from
Dec 30, 2020

Conversation

uriyyo
Copy link
Member

@uriyyo uriyyo commented Dec 27, 2020 •
edited by bedevere-bot
Loading

@rhettinger rhettinger self-assigned this Dec 27, 2020
rhettinger
rhettinger reviewed Dec 28, 2020
View reviewed changes
Objects/descrobject.c Outdated Show resolved Hide resolved
rhettinger
rhettinger requested changes Dec 28, 2020
View reviewed changes
Doc/howto/descriptor.rst Outdated Show resolved Hide resolved
Doc/howto/descriptor.rst Outdated Show resolved Hide resolved
Doc/howto/descriptor.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@uriyyo
Copy link
Member Author

uriyyo commented Dec 28, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

rhettinger
rhettinger requested changes Dec 29, 2020
View reviewed changes
Doc/howto/descriptor.rst Outdated Show resolved Hide resolved
Objects/descrobject.c Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@uriyyo
Copy link
Member Author

uriyyo commented Dec 29, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

rhettinger
rhettinger requested changes Dec 29, 2020
View reviewed changes
Objects/descrobject.c Outdated Show resolved Hide resolved
Doc/howto/descriptor.rst Outdated Show resolved Hide resolved
Doc/howto/descriptor.rst Outdated Show resolved Hide resolved
Objects/descrobject.c Outdated Show resolved Hide resolved
Objects/descrobject.c Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@uriyyo
Copy link
Member Author

uriyyo commented Dec 29, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

@rhettinger rhettinger merged commit c56387f into python:master Dec 30, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@uriyyo @adorilson
bpo-27794: Add name attribute to property class (pythonGH-23967)
9379dc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

@rhettinger rhettinger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uriyyo @bedevere-bot @rhettinger @the-knights-who-say-ni