-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-39825: fix sysconfig.get_config_var('EXT_SUFFIX') on windows #22088
Conversation
@agronholm @pitrou: any thoughts? |
This looks fine to me. @zooba Any opinions? |
Wheel does not seem to use this anyway. |
@pfmoore Would you like to opine on this? |
ping. Does this warrant a news item? |
Looks fine to me, and yeah, let's give it a NEWS item (the NEWS should be the first place people search for "why did my thing just break", so try and describe it in terms that attract the sort of query). Also, my GitHub notifications are an overflowing bottomless pit. Ping me on bpo to get my attention. |
NEWS fragment added. Since @zooba has no objections, could another core dev finish this off? |
Thanks! |
GH-23681 is a backport of this pull request to the 3.9 branch. |
… match distutils (pythonGH-22088) (cherry picked from commit c0afb7f) Co-authored-by: Matti Picus <[email protected]>
GH-23682 is a backport of this pull request to the 3.8 branch. |
… match distutils (pythonGH-22088) (cherry picked from commit c0afb7f) Co-authored-by: Matti Picus <[email protected]>
|
… match distutils (GH-22088) (cherry picked from commit c0afb7f) Co-authored-by: Matti Picus <[email protected]>
… match distutils (GH-22088) (cherry picked from commit c0afb7f) Co-authored-by: Matti Picus <[email protected]>
Did I miss something? The FREEBSD buildbot is failing with
|
Fixes
sysconfig.get_config_var('EXT_SUFFIX')
to the expected full platform_tag.extension format.May influence downstream packages like wheel (@agronholm) which use this value,
https://bugs.python.org/issue39825