bpo-41260: C impl of datetime.date.strftime() takes different keyword arg #21712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… arg The parameter was named "fmt" in the Python implementation, but it was was named "format" in the C implementation.
asottile
reviewed
Aug 3, 2020
There was a problem hiding this comment.
oh uh, I was working through this with a beginner as a mentorship opportunity -- but the patch looks correct and equivalent to what we were doing
there's another function which should be updated as well which has a similar problem
pganssle
approved these changes
Oct 20, 2020
|
Should this be backported? |
I don't think so -- since it ~technically changes the signatures of the functions slightly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter was named "fmt" in the Python implementation, but it
was was named "format" in the C implementation.
https://bugs.python.org/issue41260