bpo-40656: Clean up detect_socket() #20148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ref. discussion in #19526, @ned-deily. |
erlend-aasland
force-pushed
the
fix-issue-40656
branch
from
e7ca986 to
293f4c9
Compare
erlend-aasland
force-pushed
the
fix-issue-40656
branch
from
293f4c9 to
65eb3fb
Compare
Contributor
Author
|
@ned-deily would you mind taking a look at this? |
ned-deily
approved these changes
Nov 18, 2020
Member
ned-deily
left a comment
ned-deily
left a comment
There was a problem hiding this comment.
Looks much cleaner, thanks. I think we can dispense with a news entry for this.
Contributor
Author
|
Thanks for reviewing, @ned-deily ! |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40656