Skip to content

gh-75666: Fix Misc.unbind behaviour when funcid is given #17954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

gh-75666: Fix Misc.unbind behaviour when funcid is given #17954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
95c4404
Fix: https://bugs.python.org/issue31485
GiovaLomba Jan 6, 2020
ac6aeef
Merge pull request #1 from GiovaLomba/issue31485
GiovaLomba Jan 6, 2020
ebbdc6f
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 11, 2020
8e03203
Fix: tests on Ubuntu bionic
GiovaLomba Jan 15, 2020
0583640
Update 2020-01-11-22-09-29.bpo-31485.DSvjsY.rst
GiovaLomba Jan 15, 2020
597ef39
Update __init__.py
terryjreedy Jan 16, 2020
082db44
Fix whitespace, delete extra '.'
terryjreedy Jan 16, 2020
af41122
Leave no-funcid call as it was.
terryjreedy Jan 16, 2020
530e1d5
Remove redundant split
terryjreedy Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions Lib/tkinter/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1385,10 +1385,18 @@ def bind(self, sequence=None, func=None, add=None):
return self._bind(('bind', self._w), sequence, func, add)

def unbind(self, sequence, funcid=None):
"""Unbind for this widget for event SEQUENCE the
function identified with FUNCID."""
self.tk.call('bind', self._w, sequence, '')
if funcid:
"""Unbind for this widget the event SEQUENCE.

If FUNCID is given, only unbind the function identified with FUNCID
and also delete that command.
"""
if funcid is None:
self.tk.call('bind', self._w, sequence, '')
else:
funcs = self.tk.call('bind', self._w, sequence, None).split('\n')
keep = '\n'.join(f for f in funcs
if not f.startswith(f'if {{"[{funcid}'))
self.tk.call('bind', self._w, sequence, keep)
self.deletecommand(funcid)

def bind_all(self, sequence=None, func=None, add=None):
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2020-01-11-22-09-29.bpo-31485.DSvjsY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
https://github.com/python/cpython/pull/17954#
Copy link
Member

@serhiy-storchaka serhiy-storchaka Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a short description, not a link.

There will be a link to the corresponded issue on the tracker in any case.