bpo-38823: Clean up refleaks in faulthandler initialization. #17250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandtbucher
added
OS-windows
skip news
type-bug
vstinner
reviewed
Nov 19, 2019
Modules/faulthandler.c
Outdated
| @@ -1334,22 +1334,32 @@ PyInit_faulthandler(void) | |||
| #ifdef MS_WINDOWS | |||
| /* RaiseException() codes (prefixed by an underscore) */ | |||
| if (PyModule_AddIntConstant(m, "_EXCEPTION_ACCESS_VIOLATION", | |||
| EXCEPTION_ACCESS_VIOLATION)) | |||
| EXCEPTION_ACCESS_VIOLATION)) { | |||
| Py_DECREF(m); | |||
| return NULL; | |||
There was a problem hiding this comment.
Hum, what do you think of adding a "error:" label which does the DECREF + return NULL?
There was a problem hiding this comment.
I actually prefer that. I just wanted to keep the diffs small for all of these.
Should I make the change?
vstinner
reviewed
Nov 19, 2019
|
Thanks. I took the liberty of rewriting the commit message. |
|
Thanks @brandtbucher for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Thanks @brandtbucher for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 19, 2019
…ythonGH-17250) (cherry picked from commit ac22354) Co-authored-by: Brandt Bucher <[email protected]>
|
GH-17263 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 19, 2019
…ythonGH-17250) (cherry picked from commit ac22354) Co-authored-by: Brandt Bucher <[email protected]>
|
GH-17264 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Nov 19, 2019
…H-17250) (cherry picked from commit ac22354) Co-authored-by: Brandt Bucher <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Nov 19, 2019
…H-17250) (cherry picked from commit ac22354) Co-authored-by: Brandt Bucher <[email protected]>
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue38823