Skip to content

bpo-29592: site: skip abs_paths() when it's redundant #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2017
Merged

bpo-29592: site: skip abs_paths() when it's redundant #167

merged 2 commits into from
Mar 14, 2017

Conversation

@methane
Copy link
Member

@methane methane commented Feb 19, 2017 •
edited
Loading

[bpo-29592]
os.path.abspath() is relatively slow function. Let's skip it if possible.

@methane
bpo-29592: remove abs_paths() from site.py
1b3dfe6 
It seems redundant for now.
@methane methane added the performance Performance or resource usage label Feb 19, 2017
@methane methane changed the title bpo-29592: remove abs_paths() from site.py bpo-29592: site: skip abs_paths() when it's redundant Feb 19, 2017
@methane
Copy link
Member Author

methane commented Mar 14, 2017

@ncoghlan Would you see this?

ncoghlan
ncoghlan approved these changes Mar 14, 2017
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@methane methane merged commit 2e4e011 into python:master Mar 14, 2017
@methane methane deleted the faster-site2 branch March 14, 2017 15:52
@methane methane mentioned this pull request Jun 28, 2017
Merged
akruis added a commit to akruis/cpython that referenced this pull request Aug 16, 2018
@akruis
Stackless issue python#167: replace printf() by PySys_WriteStderr()
8a44a5f 
printf() was used to emit parts of an error message, if there is a
pending error while entering Stackless subsystem.
akruis added a commit to akruis/cpython that referenced this pull request Aug 16, 2018
@akruis
Stackless issue python#167: replace printf() by PySys_WriteStderr()
ef448f3 
printf() was used to emit parts of an error message, if there is a
pending error while entering Stackless subsystem.
(cherry picked from commit 8a44a5f)
akruis added a commit to akruis/cpython that referenced this pull request Sep 11, 2018
@akruis
Stackless issue python#167: replace printf() by PySys_WriteStderr()
85dbd4b 
printf() was used to emit parts of an error message, if there is a
pending error while entering Stackless subsystem.
(cherry picked from commit 8a44a5f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees

No one assigned

Labels

performance Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@methane @ncoghlan @the-knights-who-say-ni