bpo-37250: define tp_print for backwards compatibility #14009
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/cc @vstinner |
vstinner
reviewed
Jun 12, 2019
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Cython cannot be fixed instead? I am not sure that I like reintroducing tp_print, it is unused for 10 years...
Contributor
Author
This is being discussed at bpo-37221, please discuss there. |
Member
|
Please open a separated issue, https://bugs.python.org/issue37221 is about PyCode_New |
Member
|
I created https://bugs.python.org/issue37250 |
vstinner
changed the title
jdemeyer
force-pushed
the
define_tp_print
branch
from
22d0ccb to
08ed9c7
Compare
Contributor
Author
|
Rejected on bpo-37250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix for 3.8, so needs backport.
https://bugs.python.org/issue37250