-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
[3.14] gh-135755: Make Py_TAIL_CALL_INTERP macro private (#138981) #139120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rename Py_TAIL_CALL_INTERP to _Py_TAIL_CALL_INTERP. (cherry picked from commit 6504f20)
|
@Fidget-Spinner @corona10 @hugovk: Does it sound reasonable to you to make this macro private in 3.14? Sorry, it's a very late change in 3.14. I would be fine with rejecting this PR and leaving the macro as it is in 3.14. |
corona10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I think that it is safe to be merged at 3.14, but it's upto @hugovk want or not :)
Define "safe" ;) |
|
You don't use the configure option to enable the optimization? |
|
No, we don't run configure when building with buck2 |
|
I think this is too late for 3.14. |
Sure, I'm fine with this decision. |
Rename Py_TAIL_CALL_INTERP to _Py_TAIL_CALL_INTERP.
(cherry picked from commit 6504f20)