Skip to content

gh-138772: Add tests for Turtle.dot signature #138773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 2 commits into from
Sep 25, 2025
Merged

gh-138772: Add tests for Turtle.dot signature #138773

serhiy-storchaka merged 2 commits into from
Sep 25, 2025

Conversation

@JanEricNitschke
Copy link
Contributor

@JanEricNitschke JanEricNitschke commented Sep 11, 2025 •
edited by bedevere-app bot
Loading

PR to add some tests/clarifications and possible docs for Turtle.dot().

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Sep 11, 2025
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-app bedevere-app bot mentioned this pull request Sep 11, 2025
Closed
@aisk aisk added the skip news label Sep 11, 2025
@serhiy-storchaka serhiy-storchaka self-requested a review September 11, 2025 09:08
@JanEricNitschke JanEricNitschke marked this pull request as ready for review September 11, 2025 13:50
@JanEricNitschke
Copy link
Contributor Author

JanEricNitschke commented Sep 11, 2025

I think the test failure is unrelated.

StanFromIreland
StanFromIreland reviewed Sep 11, 2025
View reviewed changes
serhiy-storchaka
serhiy-storchaka approved these changes Sep 25, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka merged commit 2462807 into python:main Sep 25, 2025
47 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Sep 25, 2025

Thanks @JanEricNitschke for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Sep 25, 2025

Thanks @JanEricNitschke for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 25, 2025
@JanEricNitschke @miss-islington
pythongh-138772: Add tests for Turtle.dot() signature (pythonGH-138773)
9859c9a 
(cherry picked from commit 2462807)

Co-authored-by: Jan-Eric Nitschke <[email protected]>
@miss-islington-app
Copy link

miss-islington-app bot commented Sep 25, 2025

Sorry, @JanEricNitschke and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 2462807b702d9a71f0bd73a6618d4948491852a0 3.13

@bedevere-app
Copy link

bedevere-app bot commented Sep 25, 2025

GH-139326 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 25, 2025
@adorilson adorilson mentioned this pull request Sep 13, 2025
Open
21 tasks
encukou pushed a commit that referenced this pull request Oct 7, 2025
@miss-islington @JanEricNitschke
[3.14] gh-138772: Add tests for Turtle.dot() signature (GH-138773) (G…
2de18f2 
…H-139326)

(cherry picked from commit 2462807)

Co-authored-by: Jan-Eric Nitschke <[email protected]>
@hugovk
Copy link
Member

hugovk commented Nov 4, 2025

@JanEricNitschke Would you like to have a go backporting this to 3.13? See #138773 (comment).

@JanEricNitschke
Copy link
Contributor Author

JanEricNitschke commented Nov 4, 2025

@hugovk Yes, let me have a look.

PR should then look like this one i assume: #139326

@hugovk
Copy link
Member

hugovk commented Nov 4, 2025

Yes, that's right, after fixing a conflict 👍

JanEricNitschke added a commit to JanEricNitschke/cpython that referenced this pull request Nov 4, 2025
@JanEricNitschke
[3.13] pythongh-138772: Add tests for Turtle.dot() signature (pythonG…
b20464e 
…H-138773)

(cherry picked from commit 2462807)

Co-authored-by: Jan-Eric Nitschke <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 4, 2025

GH-140992 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 4, 2025
@JanEricNitschke
Copy link
Contributor Author

JanEricNitschke commented Nov 4, 2025

Created one, but not sure if i did it correctly by adding the whole test classes that were missing or if i should have just done the minimal changes instead.

hugovk added a commit that referenced this pull request Nov 5, 2025
@JanEricNitschke @hugovk
[3.13] gh-138772: Add tests for Turtle.dot() signature (GH-138773) (#…
15db242 
…140992)

Co-authored-by: Jan-Eric Nitschke <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@serhiy-storchaka serhiy-storchaka

Labels

awaiting merge skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JanEricNitschke @hugovk @serhiy-storchaka @StanFromIreland @aisk