Skip to content

GH-91048: Minor fixes for _remotedebugging & rename to _remote_debugging #133398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 5, 2025
Merged

GH-91048: Minor fixes for _remotedebugging & rename to _remote_debugging #133398

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
794075f
Minor fixes after renaming to _remotedebugging
AA-Turner May 4, 2025
90b4d18
Sorting
AA-Turner May 4, 2025
2e6b80e
Rename to _remote_debugging
AA-Turner May 4, 2025
67f415f
Merge branch 'main' into remote-debug-misc
AA-Turner May 4, 2025
163b8e4
make regen-stdlib-module-names
AA-Turner May 4, 2025
d53db6b
Merge branch 'main' into remote-debug-misc
AA-Turner May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/test_external_inspection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from _remotedebugging import get_all_awaited_by
except ImportError:
raise unittest.SkipTest(
"Test only runs when _remotedebuggingmodule is available")
"Test only runs when _remotedebugging is available")

def _make_test_script(script_dir, script_basename, source):
to_return = make_script(script_dir, script_basename, source)
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_sys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1960,7 +1960,7 @@ def _supports_remote_attaching():
PROCESS_VM_READV_SUPPORTED = False

try:
from _remotedebuggingmodule import PROCESS_VM_READV_SUPPORTED
from _remotedebugging import PROCESS_VM_READV_SUPPORTED
except ImportError:
pass

Expand Down
2 changes: 1 addition & 1 deletion Modules/Setup
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,10 +284,10 @@ PYTHONPATH=$(COREPYTHONPATH)

#*shared*
#_ctypes_test _ctypes/_ctypes_test.c
#_remotedebugging _remotedebuggingmodule.c
#_testcapi _testcapimodule.c
#_testimportmultiple _testimportmultiple.c
#_testmultiphase _testmultiphase.c
#_remotedebugging _remotedebuggingmodule.c
#_testsinglephase _testsinglephase.c

# ---
Expand Down
2 changes: 1 addition & 1 deletion Modules/Setup.stdlib.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
# Modules that should always be present (POSIX and Windows):
@MODULE_ARRAY_TRUE@array arraymodule.c
@MODULE__ASYNCIO_TRUE@_asyncio _asynciomodule.c
@MODULE__REMOTEDEBUGGING_TRUE@_remotedebugging _remotedebuggingmodule.c
@MODULE__BISECT_TRUE@_bisect _bisectmodule.c
@MODULE__CSV_TRUE@_csv _csv.c
@MODULE__HEAPQ_TRUE@_heapq _heapqmodule.c
Expand All @@ -42,6 +41,7 @@
@MODULE__PICKLE_TRUE@_pickle _pickle.c
@MODULE__QUEUE_TRUE@_queue _queuemodule.c
@MODULE__RANDOM_TRUE@_random _randommodule.c
@MODULE__REMOTEDEBUGGING_TRUE@_remotedebugging _remotedebuggingmodule.c
@MODULE__STRUCT_TRUE@_struct _struct.c

# build supports subinterpreters
Expand Down
2 changes: 1 addition & 1 deletion PCbuild/pcbuild.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
<!-- pyshellext.dll -->
<Projects Include="pyshellext.vcxproj" />
<!-- Extension modules -->
<ExtensionModules Include="_asyncio;_remotedebugging;_zoneinfo;_decimal;_elementtree;_multiprocessing;_overlapped;pyexpat;_queue;select;unicodedata;winsound;_uuid;_wmi" />
<ExtensionModules Include="_asyncio;_decimal;_elementtree;_multiprocessing;_overlapped;pyexpat;_queue;_remotedebugging;select;unicodedata;winsound;_uuid;_wmi;_zoneinfo" />
<ExtensionModules Include="_ctypes" Condition="$(IncludeCTypes)" />
<!-- Extension modules that require external sources -->
<ExternalModules Include="_bz2;_lzma;_sqlite3" />
Expand Down
1 change: 0 additions & 1 deletion Tools/build/generate_stdlib_module_names.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
'_testlimitedcapi',
'_testmultiphase',
'_testsinglephase',
'_remotedebugging',
'_xxtestfuzz',
'idlelib.idle_test',
'test',
Expand Down
92 changes: 46 additions & 46 deletions configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8077,6 +8077,7 @@ PY_STDLIB_MOD([_gdbm],
PY_STDLIB_MOD([readline],
[], [test "$with_readline" != "no"],
[$READLINE_CFLAGS], [$READLINE_LIBS])
PY_STDLIB_MOD([_remotedebugging], [test "$TEST_MODULES" = yes])
Copy link
Member Author

@AA-Turner AA-Turner May 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablogsal should we keep this "$TEST_MODULES" = yes condition? It's inherited from before the rename, but I don't know what conditions you want the module to be enabled under.

Copy link
Member

@pablogsal pablogsal May 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nop, that was from before when this was a test module. Let's remove it

Copy link
Member Author

@AA-Turner AA-Turner May 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've pushed a fix for this & also the rename to _remote_debugging. Thanks!

PY_STDLIB_MOD([_sqlite3],
[test "$have_sqlite3" = "yes"],
[test "$have_supported_sqlite3" = "yes"],
Expand Down Expand Up @@ -8119,7 +8120,6 @@ PY_STDLIB_MOD([_testbuffer], [test "$TEST_MODULES" = yes])
PY_STDLIB_MOD([_testimportmultiple], [test "$TEST_MODULES" = yes], [test "$ac_cv_func_dlopen" = yes])
PY_STDLIB_MOD([_testmultiphase], [test "$TEST_MODULES" = yes], [test "$ac_cv_func_dlopen" = yes])
PY_STDLIB_MOD([_testsinglephase], [test "$TEST_MODULES" = yes], [test "$ac_cv_func_dlopen" = yes])
PY_STDLIB_MOD([_remotedebugging], [test "$TEST_MODULES" = yes])
PY_STDLIB_MOD([xxsubtype], [test "$TEST_MODULES" = yes])
PY_STDLIB_MOD([_xxtestfuzz], [test "$TEST_MODULES" = yes])
PY_STDLIB_MOD([_ctypes_test],
Expand Down
Loading