gh-128481: indicate that the default value for FrameSummary.end_lineno changed in 3.13
#130755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
docs
ZeroIntensity
approved these changes
Mar 2, 2025
Member
Author
|
FTR, this was changed in 939fc6d. I'll merge this one before eating this evening. |
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 2, 2025
…d_lineno` changed in 3.13 (pythonGH-130755) The value taken by `FrameSummary.end_lineno` when passing `end_lineno=None` changed in pythongh-112097. Previously, a `end_lineno` could be specified to be `None` directly but since 939fc6d, passing None makes the constructor use the value of `lineno` instead. (cherry picked from commit c6513f7) Co-authored-by: Bénédikt Tran <[email protected]>
|
GH-130767 is a backport of this pull request to the 3.13 branch. |
picnixz
added a commit
that referenced
this pull request
Mar 2, 2025
…nd_lineno` changed in 3.13 (GH-130755) (#130767) gh-128481: indicate that the default value for `FrameSummary.end_lineno` changed in 3.13 (GH-130755) The value taken by `FrameSummary.end_lineno` when passing `end_lineno=None` changed in gh-112097. Previously, a `end_lineno` could be specified to be `None` directly but since 939fc6d, passing None makes the constructor use the value of `lineno` instead. (cherry picked from commit c6513f7) Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
end_lineno=NonetoFrameSummaryin Python 3.13 changed compared to Python 3.12.3.14:
cpython/Lib/traceback.py
Line 307 in 051f0e5
3.13:
cpython/Lib/traceback.py
Line 307 in 8edf17f
3.12:
cpython/Lib/traceback.py
Line 285 in c192944
traceback.FrameSummary.end_{col,line}noattributes #128481📚 Documentation preview 📚: https://cpython-previews--130755.org.readthedocs.build/