Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36540 What's New section for PEP 570 #12942

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Apr 24, 2019

@pablogsal You can either copy this into GH-12701 or land it after that has landed.

https://bugs.python.org/issue36540

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Apr 24, 2019
@gvanrossum gvanrossum added skip news and removed awaiting core review docs Documentation in the Doc dir labels Apr 24, 2019
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pablogsal
Copy link
Member

Thanks for doing this! I will land this after GH-12701 as this is more likely to have merge conflicts (as it has as the time of writing this) and I prefer not to rebase multiple times a PR that is already very big. Also, I will make a separate PR with all the doc changes that are more likely to need native speaker reviews.

@gvanrossum
Copy link
Member Author

OK, fixed the merge conflict (of my own making). Are you gonna make alpha 4?

@pablogsal
Copy link
Member

OK, fixed the merge conflict (of my own making). Are you gonna make alpha 4?

That's my intention but I am still waiting for a review from @serhiy-storchaka (Victor already approved). If we are very close to the date, I would like to merge it (maybe without the changes in inspect as Serhiy suggested) and then we can fix particular details afterwards.

Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my one optional style note, I see no problems with the grammar and style of this.

@gvanrossum
Copy link
Member Author

gvanrossum commented Apr 24, 2019 via email

@pablogsal pablogsal merged commit 843bf42 into python:master Apr 29, 2019
@gvanrossum gvanrossum deleted the whats-new-positional-args branch January 28, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants