-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-36540 What's New section for PEP 570 #12942
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for doing this! I will land this after GH-12701 as this is more likely to have merge conflicts (as it has as the time of writing this) and I prefer not to rebase multiple times a PR that is already very big. Also, I will make a separate PR with all the doc changes that are more likely to need native speaker reviews. |
a50e9d7
to
eab7dbf
Compare
OK, fixed the merge conflict (of my own making). Are you gonna make alpha 4? |
That's my intention but I am still waiting for a review from @serhiy-storchaka (Victor already approved). If we are very close to the date, I would like to merge it (maybe without the changes in inspect as Serhiy suggested) and then we can fix particular details afterwards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my one optional style note, I see no problems with the grammar and style of this.
I'll leave it up to Pablo.
|
eab7dbf
to
9923819
Compare
@pablogsal You can either copy this into GH-12701 or land it after that has landed.
https://bugs.python.org/issue36540