Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-89188: Implement PyUnicode_KIND() as a function #129412

Merged
merged 3 commits into from
Jan 30, 2025
Merged

gh-89188: Implement PyUnicode_KIND() as a function #129412

merged 3 commits into from
Jan 30, 2025

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jan 28, 2025 •
edited by bedevere-app bot
Loading

Implement PyUnicode_KIND() and PyUnicode_DATA() as function, in addition to the macros with the same names.

@vstinner
pythongh-89188: Implement PyUnicode_KIND() as a function
64be6c4 
Implement PyUnicode_KIND() and PyUnicode_DATA() as function, in
addition to the macros with the same names.
@bedevere-app bedevere-app bot mentioned this pull request Jan 28, 2025
Closed
@vstinner vstinner mentioned this pull request Jan 28, 2025
Closed
@vstinner
Copy link
Member Author

cc @indygreg @davidhewitt @encukou

encukou
encukou approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vstinner vstinner enabled auto-merge (squash) January 30, 2025 11:05
@vstinner vstinner merged commit a810cb8 into python:main Jan 30, 2025
42 checks passed
@vstinner vstinner deleted the unicode_kind branch January 30, 2025 11:27
@davidhewitt
Copy link
Contributor

Super, thank you!

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@vstinner @srinivasreddy
pythongh-89188: Implement PyUnicode_KIND() as a function (python#129412)
7a414fb 
Implement PyUnicode_KIND() and PyUnicode_DATA() as function, in
addition to the macros with the same names. The macros rely on C bit
fields which have compiler-specific layout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @davidhewitt @encukou