Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-125722: Increase minimum supported Sphinx to 8.1.3 #128922

Merged
merged 7 commits into from
Jan 20, 2025

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Jan 16, 2025

@AA-Turner AA-Turner added docs Documentation in the Doc dir needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jan 16, 2025
@hugovk
Copy link
Member

hugovk commented Jan 16, 2025

There's some if sphinx.version_info[:2] < (7, 2): in Doc/tools/extensions/c_annotations.py that can be removed.

@AA-Turner
Copy link
Member Author

There's some if sphinx.version_info[:2] < (7, 2): in Doc/tools/extensions/c_annotations.py that can be removed.

Done, I thought I'd gotten them all!

A

@hugovk
Copy link
Member

hugovk commented Jan 16, 2025

And remove the import sphinx :)

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AA-Turner AA-Turner merged commit d46b577 into python:main Jan 20, 2025
37 checks passed
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2025
@AA-Turner AA-Turner deleted the docs/sphinx-8-1-3 branch January 20, 2025 00:26
@bedevere-app
Copy link

bedevere-app bot commented Jan 20, 2025

GH-129037 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2025
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 20, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 20, 2025

GH-129038 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jan 20, 2025
AA-Turner added a commit that referenced this pull request Jan 20, 2025
AA-Turner added a commit that referenced this pull request Jan 20, 2025
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants