Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-128192: support HTTP sha-256 digest authentication as per RFC-7617 #128193

Merged
merged 15 commits into from
Dec 28, 2024
Merged

gh-128192: support HTTP sha-256 digest authentication as per RFC-7617 #128193

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
eb7fe23
support sha-256 digest authentication
calvinbui Dec 23, 2024
06cd409
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 23, 2024
1d9d1af
Update Misc/NEWS.d/next/Core_and_Builtins/2024-12-23-11-14-07.gh-issu…
calvinbui Dec 23, 2024
aea1b4e
comments regarding rfc7616
calvinbui Dec 27, 2024
5c21402
move md5-sess comment
calvinbui Dec 27, 2024
10b25ad
tests
calvinbui Dec 28, 2024
fa80be1
fix lint
calvinbui Dec 28, 2024
3c2ac12
Add name in ACKS
calvinbui Dec 28, 2024
d9e3c44
Update Lib/test/test_urllib2.py
calvinbui Dec 28, 2024
47c0148
Update Misc/NEWS.d/next/Core_and_Builtins/2024-12-23-11-14-07.gh-issu…
calvinbui Dec 28, 2024
28866f9
update what's new
calvinbui Dec 28, 2024
7f9dc2f
update docs
calvinbui Dec 28, 2024
9292180
Update Doc/whatsnew/3.14.rst
calvinbui Dec 28, 2024
2e2367d
Merge branch 'patch-1' of github.com:calvinbui/cpython into patch-1
calvinbui Dec 28, 2024
5381ff4
mention
gpshead Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/urllib/request.py
View file
Open in desktop
calvinbui marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -1182,6 +1182,8 @@ def get_algorithm_impls(self, algorithm):
elif algorithm == 'SHA':
gpshead marked this conversation as resolved.
Show resolved Hide resolved
H = lambda x: hashlib.sha1(x.encode("ascii")).hexdigest()
# XXX MD5-sess
elif algorithm == 'SHA-256':
calvinbui marked this conversation as resolved.
Show resolved Hide resolved
H = lambda x: hashlib.sha256(x.encode("ascii")).hexdigest()
else:
raise ValueError("Unsupported digest authentication "
"algorithm %r" % algorithm)
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2024-12-23-11-14-07.gh-issue-128192.02mEhD.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Support digest authentication algorithm SHA-256 in :mod:`urllib.request`.
calvinbui marked this conversation as resolved.
Show resolved Hide resolved
Loading