Skip to content

bpo-36035: fix rglob for broken links #11988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 21, 2019
Merged

bpo-36035: fix rglob for broken links #11988

merged 5 commits into from
May 21, 2019

Conversation

@jstucke
Copy link
Contributor

@jstucke jstucke commented Feb 22, 2019 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Feb 22, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

eamanu
eamanu reviewed Feb 22, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#11964 duplicated

@csabella csabella requested a review from pitrou May 21, 2019 14:23
pitrou
pitrou approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for doing this!

@pitrou pitrou merged commit d5c120f into python:master May 21, 2019
@miss-islington
Copy link
Contributor

miss-islington commented May 21, 2019

Thanks @jstucke for the PR, and @pitrou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented May 21, 2019

GH-13468 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

miss-islington commented May 21, 2019

Sorry, @jstucke and @pitrou, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d5c120f7eb6f2a9cdab282a5d588afed307a23df 3.6

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2019
@jstucke @miss-islington
bpo-36035: fix Path.rglob for broken links (pythonGH-11988)
1cb2a9e 
Links creating an infinite symlink loop would raise an exception.
(cherry picked from commit d5c120f)

Co-authored-by: Jörg Stucke <[email protected]>
@pitrou
Copy link
Member

pitrou commented May 21, 2019

Ok, I won't bother about 3.6 personally (is it still open for regular bug fixes?).

@miss-islington
Copy link
Contributor

miss-islington commented May 21, 2019

Thanks @jstucke for the PR, and @pitrou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2019
@jstucke @miss-islington
bpo-36035: fix Path.rglob for broken links (pythonGH-11988)
e805a98 
Links creating an infinite symlink loop would raise an exception.
(cherry picked from commit d5c120f)

Co-authored-by: Jörg Stucke <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented May 21, 2019

GH-13469 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 21, 2019
@miss-islington
[3.7] bpo-36035: fix Path.rglob for broken links (GH-11988) (GH-13469)
aea49b1 
Links creating an infinite symlink loop would raise an exception.
(cherry picked from commit d5c120f)


Co-authored-by: Jörg Stucke <[email protected]>


https://bugs.python.org/issue36035
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

+1 more reviewer

@eamanu eamanu eamanu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pitrou pitrou

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jstucke @the-knights-who-say-ni @miss-islington @bedevere-bot @pitrou @eamanu