-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-74929: PEP 667 general docs update #119201
gh-74929: PEP 667 general docs update #119201
Conversation
* expand on What's New entry for PEP 667 * review (and update) all mentions of "locals" in documentation C API documentation updates will be added in a separate PR
In addition to the inline notes in the PR, I also need to search for references to |
Does the following refer to something other than the
|
I did not see any grammar or spelling issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a handful of comments. Overall looks very good, but suggest a few minor revisions for clarity.
There are several C API additions and updates as described in the PEP. Most of them will be covered in |
I realised that I was using the Aus/UK spelling of I also added an inline note to the glossary entry pointing out that most optimizations are applied to all scopes, there's just a subset that are only valid when the local and nonlocal variables names are known at compile time. To avoid more conflicts with sprint changes, I will merge this version once CI is happy. |
Capturing the commit message, just in case something fails before the auto-merge lands:
|
Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
* expand on What's New entry for PEP 667 (including porting notes) * define 'optimized scope' as a glossary term * cover comprehensions and generator expressions in locals() docs * review all mentions of "locals" in documentation (updating if needed) * review all mentions of "f_locals" in documentation (updating if needed) (cherry picked from commit e870c85) Co-authored-by: Alyssa Coghlan <[email protected]>
GH-119291 is a backport of this pull request to the 3.13 branch. |
* expand on What's New entry for PEP 667 (including porting notes) * define 'optimized scope' as a glossary term * cover comprehensions and generator expressions in locals() docs * review all mentions of "locals" in documentation (updating if needed) * review all mentions of "f_locals" in documentation (updating if needed)
locals
andf_locals
in documentationC API documentation updates will be added in a separate PR
📚 Documentation preview 📚: https://cpython-previews--119201.org.readthedocs.build/