-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-114785: Remove Porting from Python2
how-to
#114805
Conversation
This page does have some traffic. From the Plausible 30-day trial, Instead of outright deleting and serving a 404 to visitors, can we avoid contributing to linkrot and put something else useful on the page? Are there some useful external resources we can link to? |
@hugovk great that we have these numbers! I didn't know we collect them. |
This guide by Fedora looks good: https://portingguide.readthedocs.io Here's a 2.5 hour PyCon 2020 tutorial: https://www.youtube.com/watch?v=JgIgEjASOlk And a tutorial by Digital Ocean: https://www.digitalocean.com/community/tutorials/how-to-port-python-2-code-to-python-3 And by ActiveState: https://www.activestate.com/blog/how-to-migrate-python-2-applications-to-python-3/ We could keep these three paragraphs from the abstract (shift them out of the abstract and delete the abstract):
And add links to: And then links to those resources. |
Is there any reason not to think that search engines won't update to the e.g. 3.12 version of that page? |
Sorry, I don't understand your question :( |
I think the question is: If we delete the page at https://docs.python.org/3/howto/pyporting.html, will search engines stop suggesting it and instead start suggesting https://docs.python.org/3.12/howto/pyporting.html? Maybe they will? SEO is a mysterious art. We still sometimes get reports that old version pages shown up results. We do have this in the 3.12 page which tells search engines the canonical page is the one deleted in this PR, which might confuse things: <link rel="canonical" href="https://docs.python.org/3/howto/pyporting.html" /> Perhaps we can change that to point to In any case, even if search engines do start pointing to To sort that, we should either keep a stub page, or figure out some redirects from https://docs.python.org/3/howto/pyporting.html to elsewhere. I favour a stub page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Replacing it with a stub and link list, as @hugovk suggested (and as we did for cporting-howto), sounds good to me. That way, people who end up there have a place to go. (Disclosure: I “maintain” Fedora's guide. Not that there's much to maintain there, with the disclaimer that it'll get you up to Python 3.6 and then you're on your own.) Is it possible to remove it from the rendered tables of contents? That might be appropriate too. |
Yes, with https://www.sphinx-doc.org/en/master/usage/restructuredtext/field-lists.html#special-metadata-fields For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looking good!
Co-authored-by: Hugo van Kemenade <[email protected]>
I remove my review since the PR changed
Anything else left to do? Or can we proceed? :) |
I think this is ready to merge, would you like to use your new powers and do the honours? :) |
Sure 🎉 |
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…ythonGH-114805) Keep the page though, because people might still rely on it (the traffic shows that they do). Instead of our own manual we now give links to the 3rd-party ones. (cherry picked from commit 705c76d) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
GH-115327 is a backport of this pull request to the 3.12 branch. |
…ythonGH-114805) Keep the page though, because people might still rely on it (the traffic shows that they do). Instead of our own manual we now give links to the 3rd-party ones. (cherry picked from commit 705c76d) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
GH-115328 is a backport of this pull request to the 3.11 branch. |
@hugovk I am not sure about the backports. Maybe we should keep older versions as-is? |
Please don't backport a removal. |
The reason for making these changes was to help people because the existing info is outdated and points to tools that don't support Python 2, and they'll struggle if they try and follow the advice. If we don't backport to 3.12 (= I think it should at least be backported to 3.12. Similarly for 3.11: we want people to have helpful information. Let's put that in front of people in as many places as possible (= bugfix branches).
Good point, and update the link to point to the last version with the old guide. |
I also have
link in the new docs, so I would have to update it to be I see pros and cons with both ways, I will listen to others here :) |
…ython#114805) Keep the page though, because people might still rely on it (the traffic shows that they do). Instead of our own manual we now give links to the 3rd-party ones. Co-authored-by: Hugo van Kemenade <[email protected]>
…H-114805) (GH-115327) Keep the page though, because people might still rely on it (the traffic shows that they do). Instead of our own manual we now give links to the 3rd-party ones. (cherry picked from commit 705c76d) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
…H-114805) (GH-115328) Keep the page though, because people might still rely on it (the traffic shows that they do). Instead of our own manual we now give links to the 3rd-party ones. (cherry picked from commit 705c76d) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
I feel a pleasant warmth inside by proposing this change 😆
However, I don't insist on making it: it might still be useful for someone, even outdated.
In my opinion - it is not really helpful anymore.
📚 Documentation preview 📚: https://cpython-previews--114805.org.readthedocs.build/en/114805/howto/pyporting.html