-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.11] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) #114118
Conversation
acf3006
to
453b2e0
Compare
…en __getattr__ (pythonGH-113359) cherry picked from commit 04fabe2 Adjusted for 3.11, because exception printing also happens in C code. Co-authored-by: Jérome Perrin <[email protected]> Co-authored-by: Irit Katriel <[email protected]>
453b2e0
to
8c12e96
Compare
This is not a trivial backport, cherry-picking the commit was not enough, there is also C code to format exceptions in 3.11 branch. The CI is OK, but I am not familiar with C programming and python C API so I might have made mistakes here. |
Misc/NEWS.d/next/Library/2023-12-21-14-55-06.gh-issue-113358.nRkiSL.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can actually do this because we know it's not NULL.
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 2c882e0 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
There's a refleak test failure. |
Thank you ! I could reproduce locally and pushed a fix. The problem was with missing decref on values returned by |
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit a4613e2 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit d72e989 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
(cherry picked from commit 04fabe2)
Adjusted for 3.11, because exception printing also happens in C code.