Skip to content

gh-111347: Remove wrong assertion in test_sendfile #111377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 29, 2023
Merged

gh-111347: Remove wrong assertion in test_sendfile #111377

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
22a1e87
gh-111347: Remove wrong assertion in test_sendfile
zcxsythenew Oct 27, 2023
272ab33
gh-111347: Remove wrong assertion in test_sendfile
zcxsythenew Oct 27, 2023
0e58411
Rewrite condition differently
gvanrossum Oct 29, 2023
3f40f8e
Add a comment explaining why we skip the assert
gvanrossum Oct 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Lib/test/test_asyncio/test_sendfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,8 +470,10 @@ def test_sendfile_close_peer_in_the_middle_of_receiving(self):

self.assertTrue(1024 <= srv_proto.nbytes < len(self.DATA),
srv_proto.nbytes)
self.assertTrue(1024 <= self.file.tell() < len(self.DATA),
self.file.tell())
if not (sys.platform == 'win32'
and isinstance(self.loop, asyncio.ProactorEventLoop)):
self.assertTrue(1024 <= self.file.tell() < len(self.DATA),
self.file.tell())
self.assertTrue(cli_proto.transport.is_closing())

def test_sendfile_fallback_close_peer_in_the_middle_of_receiving(self):
Expand Down