Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-105481: remove HAS_ARG, HAS_CONST, IS_JUMP_OPCODE, IS_PSEUDO_OPCODE and replace by their new versions #105865

Merged
merged 7 commits into from
Jun 17, 2023
Merged

gh-105481: remove HAS_ARG, HAS_CONST, IS_JUMP_OPCODE, IS_PSEUDO_OPCODE and replace by their new versions #105865

merged 7 commits into from
Jun 17, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jun 16, 2023 •
edited by bedevere-bot
Loading

@iritkatriel iritkatriel requested a review from markshannon as a code owner June 16, 2023 18:51
@bedevere-bot bedevere-bot mentioned this pull request Jun 16, 2023
Closed
@iritkatriel iritkatriel requested a review from gvanrossum June 16, 2023 19:39
gvanrossum
gvanrossum approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need any doc update for dis.stack_effect (or is it opcode.stack_effect now that it no longer requires the presence of oparg to match the requirements of the opcode.

@iritkatriel
Copy link
Member Author

The doc doesn't mention the arg check issue. Should I add a versionchanged note anyway?

@gvanrossum
Copy link
Member

Might as well.

@iritkatriel iritkatriel added interpreter-core (Objects, Python, Grammar, and Parser dirs) stdlib Python modules in the Lib dir and removed skip news labels Jun 17, 2023
@iritkatriel iritkatriel merged commit 14d0126 into python:main Jun 17, 2023
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jun 18, 2023
@iritkatriel @gvanrossum
pythongh-105481: remove HAS_ARG, HAS_CONST, IS_JUMP_OPCODE, IS_PSEUDO…
99bdf61 
…_OPCODE and replace by their new versions (python#105865)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) stdlib Python modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iritkatriel @gvanrossum @arhadthedev @bedevere-bot