[WIP] GH-89727: Fix shutil.rmtree() recursion error on deep trees.
#103164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `follow_junctions` argument to `pathlib.Path.walk()`. When set to false, directory junctions are treated as files. Add an `fwalk()` method to `pathlib.Path`, analogous to `os.fwalk()`. Implement `shutil.rmtree()` using `pathlib.Path.walk()` and `fwalk()`.
arhadthedev
reviewed
Apr 12, 2023
|
Withdrawing this PR - it's out of date, and I'd like to keep the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
follow_junctionsargument topathlib.Path.walk(). When set to false, directory junctions are treated as files.Add an
_fwalk()method topathlib.Path, similar toos.fwalk()except in its treatment of symlinks.(This method could be made public in future if desired).
Implement
shutil.rmtree()usingpathlib.Path.walk()or_fwalk().