-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
gh-102542 Refactor the mime audio module #102540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
496bbec
Refactor the mime audio module
JosephSBoyle 3561ee9
Improve comparisons in _infer_subtype
JosephSBoyle 15cd8ad
Add a test for inferring the audio content subtypes
JosephSBoyle 5b26332
Make the infer audio content subtypes test more robust
JosephSBoyle 1b4b061
Remove newly added redundant tests
JosephSBoyle 3ebbfae
Merge branch 'main' into refactor-mime-audio
JosephSBoyle 114e324
Merge branch 'python:main' into refactor-mime-audio
JosephSBoyle 1f1efa5
Merge branch 'main' into refactor-mime-audio
JosephSBoyle 9d21be1
Merge branch 'main' into refactor-mime-audio
JosephSBoyle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the behavior if _subtype is '' (or any other non-None null value). Someone other than me needs to agree with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct. Falsey values other than
None
such as:0
,False
,''
and empty collections will all fall back to the secondor
operand:_infer_subtype(_audiodata)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally prefer more explicit tests than just "falseiness" when a more explicit type is indicated. In this case
_subtype=None
defaults to None to mean that this argument wasn't given.