Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-98831: register instructions have 0 pushes and pops #101163

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jan 19, 2023

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

Maybe it's time to add some tests for the generated opcode metadata (but I'm not asking for that now).

@iritkatriel
Copy link
Member Author

It failed very quickly when I tried to use it (the sanity check we added in the compiler flipped).

@gvanrossum
Copy link
Member

gvanrossum commented Jan 19, 2023

Is it ready to merge?

Note: there are other things in the generator that probably don't work, e.g. there are some commented-out out.emit(f"JUMPBY(OPSIZE(... calls. But those might be not needed if we go ahead with the variable-length scheme.

@iritkatriel
Copy link
Member Author

Is it ready to merge?

I think so.

Note: there are other things in the generator that probably don't work, e.g. there are some commented-out out.emit(f"JUMPBY(OPSIZE(... calls. But those might be not needed if we go ahead with the variable-length scheme.

I'm not doing variable length instructions now. I'm adding the plumbing in the compiler, and for now supporting only 1 oparg (so I can do RETURN_VALUE from a tmp register). There's plenty there to keep me busy for now.

@iritkatriel iritkatriel merged commit 8a2d4f4 into python:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants