GH-100766: Note that locale.LC_MESSAGES is not universal (GH-100702) #100702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FFY00
changed the title
FFY00
approved these changes
Jan 5, 2023
FFY00
added
needs backport to 3.10
FFY00
changed the title
|
GH-100767 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 5, 2023
…nGH-100702) (cherry picked from commit 105e373) Co-authored-by: Tzu-ping Chung <[email protected]>
|
GH-100768 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 5, 2023
…nGH-100702) (cherry picked from commit 105e373) Co-authored-by: Tzu-ping Chung <[email protected]>
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Jan 5, 2023
* main: pythonGH-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction. (pythonGH-100753) pythonGH-100766: Note that locale.LC_MESSAGES is not universal (pythonGH-100702)
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Jan 5, 2023
* main: pythonGH-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction. (pythonGH-100753) pythonGH-100766: Note that locale.LC_MESSAGES is not universal (pythonGH-100702) Drop myself from pathlib maintenance (python#100757) pythongh-100739: Respect mock spec when checking for unsafe prefixes (python#100740)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LC_MESSAGESvalue inlocaleis not universally available. The value is generally imported from C headers throughlocalemodule.c. The sourc notes this specifically:cpython/Lib/locale.py
Lines 25 to 26 in 73097d9
This makes the fact more visible to users only reading the documentation.
locale.LC_MESSAGESis not universal #100766