Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error handling in the compiler is inconsistent #99955

Closed
iritkatriel opened this issue Dec 2, 2022 · 3 comments · Fixed by #101412
Closed

error handling in the compiler is inconsistent #99955

iritkatriel opened this issue Dec 2, 2022 · 3 comments · Fixed by #101412
Assignees
@iritkatriel
Labels
type-feature A feature request or enhancement

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Dec 2, 2022 •
edited by bedevere-bot
Loading

In compile.c some function return 0 for failure and 1 for success, and some return -1 for failure and 0 for success.

Should be -1 / 0 consistently.

Linked PRs
@iritkatriel iritkatriel added the type-feature A feature request or enhancement label Dec 2, 2022
@bedevere-bot bedevere-bot mentioned this issue Dec 2, 2022
Merged
iritkatriel added a commit that referenced this issue Dec 2, 2022
@iritkatriel
gh-99955: standardize return values of functions in assembler and opt…
ab02262 
…imizer. (#99956)
@ramvikrams
Copy link
Contributor

can I still work on this or is it done

@iritkatriel
Copy link
Member Author

iritkatriel commented Dec 3, 2022 •
edited
Loading

I’m working on it, it’s mostly done. Assigning to myself to finish.

@iritkatriel iritkatriel self-assigned this Dec 3, 2022
@iritkatriel iritkatriel changed the title error handling in the compiler in inconsistent error handling in the compiler is inconsistent Dec 3, 2022
@ramvikrams
Copy link
Contributor

ok

@bedevere-bot bedevere-bot mentioned this issue Dec 5, 2022
Merged
iritkatriel added a commit that referenced this issue Dec 12, 2022
@iritkatriel
gh-99955: standardize return values of functions in compiler's code-g…
e4ea33b 
…en (#100010)
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Dec 13, 2022
@iritkatriel
pythongh-99955: undef ERROR and SUCCESS before redefining (fixes sani…
a903bf8 
…tizer warning)
@bedevere-bot bedevere-bot mentioned this issue Dec 13, 2022
Merged
iritkatriel added a commit that referenced this issue Dec 13, 2022
@iritkatriel
gh-99955: undef ERROR and SUCCESS before redefining (fixes sanitizer …
985a710 
…warning) (#100215)
carljm added a commit to carljm/cpython that referenced this issue Dec 14, 2022
@carljm
Merge branch 'main' into typedocs
53d33a1 
* main: (103 commits)
  pythongh-100248: Add missing `ssl_shutdown_timeout` parameter in `asyncio` docs (python#100249)
  Assorted minor fixes for specialization stats. (pythonGH-100219)
  pythongh-100176: venv: Remove redundant compat code for Python <= 3.2 (python#100177)
  pythonGH-100222: Redefine _Py_CODEUNIT as a union to clarify structure of code unit. (pythonGH-100223)
  pythongh-99955: undef ERROR and SUCCESS before redefining (fixes sanitizer warning) (python#100215)
  pythonGH-100206: use versionadded for the addition of sysconfig.get_default_scheme (python#100207)
  pythongh-81057: Move _Py_RefTotal to the "Ignored Globals" List (pythongh-100203)
  pythongh-81057: Move Signal-Related Globals to _PyRuntimeState (pythongh-100085)
  pythongh-81057: Move faulthandler Globals to _PyRuntimeState (pythongh-100152)
  pythongh-81057: Move tracemalloc Globals to _PyRuntimeState (pythongh-100151)
  pythonGH-100143: Improve collecting pystats for parts of runs (pythonGH-100144)
  pythongh-99955: standardize return values of functions in compiler's code-gen (python#100010)
  pythongh-79218: Define `MS_WIN64` macro for Mingw-w64 64bit on Windows (pythonGH-100137)
  Fix: typo (Indention) (pythonGH-99904)
  pythongh-96715 Remove redundant NULL check in `profile_trampoline` function (python#96716)
  pythongh-100176: remove incorrect version compatibility check from argument clinic (python#100190)
  clarify the 4300-digit limit on int-str conversion (python#100175)
  pythongh-70393: Clarify mention of "middle" scope (python#98839)
  pythongh-99688: Fix outdated tests in test_unary (python#99712)
  pythongh-100174: [Enum] Correct PowersOfThree example. (pythonGH-100178)
  ...
@iritkatriel iritkatriel reopened this Jan 29, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Jan 29, 2023
@iritkatriel
pythongh-99955: use SUCCESS/ERROR return values in optimizer and asse…
df283cd 
…mbler
@bedevere-bot bedevere-bot mentioned this issue Jan 29, 2023
Merged
iritkatriel added a commit that referenced this issue Jan 31, 2023
@iritkatriel
gh-99955: use SUCCESS/ERROR return values in optimizer and assembler.…
af7b2db 
… Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (#101412)
mdboom pushed a commit to mdboom/cpython that referenced this issue Jan 31, 2023
@iritkatriel @mdboom
pythongh-99955: use SUCCESS/ERROR return values in optimizer and asse…
e30789d 
…mbler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (python#101412)
carljm added a commit to carljm/cpython that referenced this issue Jan 31, 2023
@carljm
Merge branch 'main' into inlinecomp2
ed3209b 
* main:
  pythongh-101440: fix json snippet error in logging-cookbook.rst (python#101439)
  pythongh-99276 - Updated Doc/faq/general.rst (python#101396)
  Add JOBS parameter to docs Makefile (python#101395)
  pythongh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL (python#101443)
  pythongh-77607: Improve accuracy of os.path.join docs (python#101406)
  Fixes typo in asyncio.TaskGroup context manager code example (python#101449)
  pythongh-98831: Clean up and add cache size static_assert to macro (python#101442)
  pythongh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (python#101412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iritkatriel iritkatriel

Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
2 participants
@iritkatriel @ramvikrams