Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more deprecated importlib APIs from Python 3.12 #98040

Closed
6 tasks done
warsaw opened this issue Oct 7, 2022 · 8 comments
Closed
6 tasks done

Remove more deprecated importlib APIs from Python 3.12 #98040

warsaw opened this issue Oct 7, 2022 · 8 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@warsaw
Copy link
Member

warsaw commented Oct 7, 2022 •
edited by bedevere-bot
Loading

Issue #97850 is the meta issue tracking removals of long deprecated functions from importlib. This ticket tracks just the removals of the following previously deprecated APIs:

  • find_loader()
  • find_module()
  • imp module
  • importlib.abc.Finder
  • pkgutil.ImpImporter
  • pkgutil.ImpLoader

Linked PRs
@warsaw warsaw added the type-bug An unexpected behavior, bug, or error label Oct 7, 2022
@warsaw
Copy link
Member Author

warsaw commented Oct 7, 2022 •
edited
Loading

Questions:

  • importlib.abs.PathEntryFinder has this comment: "We don't define find_spec() here since that would break hasattr checks we do to support backward compatibility." Do we need to define find_spec() in this ABC?

@warsaw warsaw changed the title Remove find_module() and find_loader() from Python 3.12 Remove find_module(), find_loader(), and NullImporter from Python 3.12 Oct 7, 2022
@warsaw warsaw changed the title Remove find_module(), find_loader(), and NullImporter from Python 3.12 Remove more deprecated importlib APIs from Python 3.12 Oct 7, 2022
@bedevere-bot bedevere-bot mentioned this issue Oct 7, 2022
Merged
@warsaw warsaw mentioned this issue Oct 9, 2022
Closed
1 task
@warsaw
Copy link
Member Author

warsaw commented Oct 9, 2022 •
edited
Loading

pkgutil.ImpImporter cannot be removed since pip 22.2.2 still uses it. This is also going to keep pkgutil.ImpLoader and the imp module around. I'm going to pause work on this branch until there's a pip upstream resolution.

@warsaw warsaw mentioned this issue Oct 10, 2022
Closed
warsaw added a commit to warsaw/cpython that referenced this issue Oct 23, 2022
@warsaw
pythongh-98040: Remove just the imp module
1c9c352
@bedevere-bot bedevere-bot mentioned this issue Oct 23, 2022
Merged
@kdeldycke kdeldycke mentioned this issue Jan 2, 2023
Closed
1 task
@bedevere-bot bedevere-bot mentioned this issue Mar 9, 2023
Merged
@hugovk
Copy link
Member

hugovk commented Apr 8, 2023

Little reminder: we're a month away from the beta freeze to remove these, or to bump removal to 3.13.

@warsaw
Copy link
Member Author

warsaw commented Apr 8, 2023

My plan is to complete this work at the 2023 PyCon sprints.

CAM-Gerlach pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@warsaw @CAM-Gerlach
pythongh-98040: Remove just the imp module
44cd65d
@warsaw warsaw mentioned this issue Apr 19, 2023
Merged
ericsnowcurrently added a commit that referenced this issue Apr 19, 2023
@ericsnowcurrently
gh-98040: Move the Single-Phase Init Tests Out of test_imp (gh-102561)
6be7aee 
I recently added some tests to test_imp, but @warsaw is removing that file in gh-98573. The tests are worth keeping so here I'm moving them to test_import.
carljm added a commit to carljm/cpython that referenced this issue Apr 20, 2023
@carljm
Merge branch 'main' into superopt
5c0a21c 
* main: (24 commits)
  pythongh-98040: Move the Single-Phase Init Tests Out of test_imp (pythongh-102561)
  pythongh-83861: Fix datetime.astimezone() method (pythonGH-101545)
  pythongh-102856: Clean some of the PEP 701 tokenizer implementation (python#103634)
  pythongh-102856: Skip test_mismatched_parens in WASI builds (python#103633)
  pythongh-102856: Initial implementation of PEP 701 (python#102855)
  pythongh-103583: Add ref. dependency between multibytecodec modules (python#103589)
  pythongh-83004: Harden msvcrt further (python#103420)
  pythonGH-88342: clarify that `asyncio.as_completed` accepts generators yielding tasks (python#103626)
  pythongh-102778: IDLE - make sys.last_exc available in Shell after traceback (python#103314)
  pythongh-103582: Remove last references to `argparse.REMAINDER` from docs (python#103586)
  pythongh-103583: Always pass multibyte codec structs as const (python#103588)
  pythongh-103617: Fix compiler warning in _iomodule.c (python#103618)
  pythongh-103596: [Enum] do not shadow mixed-in methods/attributes (pythonGH-103600)
  pythonGH-100530: Change the error message for non-class class patterns (pythonGH-103576)
  pythongh-95299: Remove lingering setuptools reference in installer scripts (pythonGH-103613)
  [Doc] Fix a typo in optparse.rst (python#103504)
  pythongh-101100: Fix broken reference `__format__` in `string.rst` (python#103531)
  pythongh-95299: Stop installing setuptools as a part of ensurepip and venv (python#101039)
  pythonGH-103484: Docs: add linkcheck allowed redirects entries for most cases (python#103569)
  pythongh-67230: update whatsnew note for csv changes (python#103598)
  ...
This was referenced Apr 28, 2023
Closed
Closed
Closed
Closed
warsaw added a commit that referenced this issue Apr 28, 2023
@warsaw
gh-98040: Remove just the imp module (#98573)
e1f1464
This was referenced Apr 29, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Open
jan-cerny added a commit to jan-cerny/scap-security-guide that referenced this issue Jul 11, 2023
@jan-cerny
Stop using "imp" module
9fd541b 
Fixes broken build on Fedora Rawhide.

The deprecated importlib API has been removed from Python 3.12,
see python/cpython#98040.

Addressing:

Traceback (most recent call last):
  File "/builddir/build/BUILD/scap-security-guide-0.1.69/build-scripts/build_templated_content.py", line 9, in <module>
    import ssg.templates
  File "/builddir/build/BUILD/scap-security-guide-0.1.69/ssg/templates.py", line 5, in <module>
    import imp
ModuleNotFoundError: No module named 'imp'
@jan-cerny jan-cerny mentioned this issue Jul 11, 2023
Merged
musicinmybrain added a commit to musicinmybrain/grpc that referenced this issue Jul 17, 2023
@musicinmybrain
Do not use importlib find_module API
095ddf0 
This API was removed in Python 3.12
(python/cpython#98040).

Fixes Python 3.12 support in grpcio tests.
musicinmybrain added a commit to musicinmybrain/grpc that referenced this issue Jul 17, 2023
@musicinmybrain
More importlib find_module migration
efd45b1 
Do not use importlib find_module API in bazel/_gevent_test_main.py

This API was removed in Python 3.12
(python/cpython#98040).
@alcir alcir mentioned this issue Jul 19, 2023
Closed
rhmdnd pushed a commit to openshift/cac-content-fork that referenced this issue Jul 21, 2023
@jan-cerny @rhmdnd
Stop using "imp" module
2d78807 
Fixes broken build on Fedora Rawhide.

The deprecated importlib API has been removed from Python 3.12,
see python/cpython#98040.

Addressing:

Traceback (most recent call last):
  File "/builddir/build/BUILD/scap-security-guide-0.1.69/build-scripts/build_templated_content.py", line 9, in <module>
    import ssg.templates
  File "/builddir/build/BUILD/scap-security-guide-0.1.69/ssg/templates.py", line 5, in <module>
    import imp
ModuleNotFoundError: No module named 'imp'
@sanjayankur31 sanjayankur31 mentioned this issue Jul 28, 2023
Closed
Closed
@jayaddison jayaddison mentioned this issue Sep 1, 2023
Open
gnossen pushed a commit to grpc/grpc that referenced this issue Sep 6, 2023
@musicinmybrain
[Test] Do not use importlib find_module API, removed in Python 3.12 (#…
efc3843 
…33506)

This API was [removed in Python
3.12](python/cpython#98040).

Fixes Python 3.12 support in `grpcio` tests.

This is relevant to #33063.

See also #33492.

----

I have actually only tested this in a form backported to grpc 1.48.4,
and I am not able to test the change to `bazel/_gevent_test_main.py`
directly. However, the backported form allows me to build grpc 1.48.4
for Fedora Rawhide with Python 3.12, and I believe the version in this
PR to be correct—especially, if CI passes for Python 3.11, I believe
this part of the test code will continue to work in Python 3.12.
@brentvollebregt brentvollebregt mentioned this issue Oct 11, 2023
Closed
@poing poing mentioned this issue Oct 12, 2023
Closed
@dom0 dom0 mentioned this issue Oct 14, 2023
Open
This was referenced Oct 15, 2023
Closed
Open
@SanderWegter SanderWegter mentioned this issue Nov 3, 2023
Open
@Czaki Czaki mentioned this issue Nov 10, 2023
Closed
This was referenced Nov 25, 2023
Closed
Closed
@WilliamJamieson WilliamJamieson mentioned this issue Nov 27, 2023
Merged
7 tasks
openstack-mirroring pushed a commit to openstack/oslotest that referenced this issue Jan 7, 2024
@arkamar
Replace find_module function
104cb89 
find_module function was deprecated in Python 3.4 [1] and later removed
in Python 3.12 [2], the find_spec function should be used instead. This
change is necessary for proper Python 3.12 support.

[1] https://docs.python.org/3.4/library/importlib.html#importlib.abc.MetaPathFinder.find_module
[2] python/cpython#98040

Change-Id: I8354918d6548192dea3492eb2ee682d323559912
Signed-off-by: Petr Vaněk <[email protected]>
openstack-mirroring pushed a commit to openstack/openstack that referenced this issue Jan 7, 2024
@openstack-gerrit
Update git submodules
b944a4e 
* Update oslotest from branch 'master'
  to e8c5d7093a2d999ee343497767eac54126b79ee6
  - Merge "Replace find_module function"
  - Replace find_module function
    
    find_module function was deprecated in Python 3.4 [1] and later removed
    in Python 3.12 [2], the find_spec function should be used instead. This
    change is necessary for proper Python 3.12 support.
    
    [1] https://docs.python.org/3.4/library/importlib.html#importlib.abc.MetaPathFinder.find_module
    [2] python/cpython#98040
    
    Change-Id: I8354918d6548192dea3492eb2ee682d323559912
    Signed-off-by: Petr Vaněk <[email protected]>
@JaCraig JaCraig mentioned this issue Feb 22, 2024
Closed
4 tasks
@wallrite wallrite mentioned this issue Apr 18, 2024
Closed
@Jakuje Jakuje mentioned this issue Apr 19, 2024
Open
yibe added a commit to yibe/ldoce5viewer-pyqt5 that referenced this issue May 10, 2024
@yibe
Fix errors with Python 3.12
a75c3d5 
python/cpython#89336
python/cpython#98040
@ferdnyc ferdnyc mentioned this issue Jun 16, 2024
Open
@yuzibo yuzibo mentioned this issue Jul 2, 2024
Open
@wsyxbcl wsyxbcl mentioned this issue Aug 13, 2024
Closed
@vss-2 vss-2 mentioned this issue Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@vstinner @warsaw @encukou @hugovk and others