Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation of END_ASYNC_FOR is out of date and incorrect #101454

Closed
iritkatriel opened this issue Jan 31, 2023 · 0 comments · Fixed by #101455
Closed

Documentation of END_ASYNC_FOR is out of date and incorrect #101454

iritkatriel opened this issue Jan 31, 2023 · 0 comments · Fixed by #101455
Labels
3.11 only security fixes 3.12 bugs and security fixes docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Jan 31, 2023 •
edited by bedevere-bot
Loading

Documentation of END_ASYNC_FOR is both out of date and incorrect:

Terminates an [async for](https://docs.python.org/3.12/reference/compound_stmts.html#async-for) loop. Handles an exception raised when awaiting a next item. If STACK[-1] is [StopAsyncIteration](https://docs.python.org/3.12/library/exceptions.html#StopAsyncIteration) pop 3 values from the stack and restore the exception state using the second of them. Otherwise re-raise the exception using the value from the stack. An exception handler block is removed from the block stack.

Linked PRs
@iritkatriel iritkatriel added the type-bug An unexpected behavior, bug, or error label Jan 31, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Jan 31, 2023
@iritkatriel
pythongh-101454: fix documentation for END_ASYNC_FOR
d84ced2
@iritkatriel iritkatriel mentioned this issue Jan 31, 2023
Merged
@iritkatriel iritkatriel added docs Documentation in the Doc dir 3.11 only security fixes 3.12 bugs and security fixes labels Feb 1, 2023
iritkatriel added a commit that referenced this issue Feb 1, 2023
@iritkatriel
gh-101454: fix documentation for END_ASYNC_FOR (#101455)
62251c3
@bedevere-bot bedevere-bot mentioned this issue Feb 1, 2023
Merged
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Feb 1, 2023
@iritkatriel
pythongh-101454: fix documentation for END_ASYNC_FOR (python#101455)
21d2735 
(cherry picked from commit 62251c3)
iritkatriel added a commit that referenced this issue Feb 1, 2023
@iritkatriel
[3.11] gh-101454: fix documentation for END_ASYNC_FOR (#101455) (#101493
c796d34 
)

gh-101454: fix documentation for END_ASYNC_FOR (#101455)

(cherry picked from commit 62251c3)
carljm added a commit to carljm/cpython that referenced this issue Feb 1, 2023
@carljm
Merge branch 'main' into inlinecomp2
8b76051 
* main:
  pythongh-98831: rewrite PUSH_EXC_INFO and conditional jumps in the instruction definition DSL (python#101481)
  pythongh-98831: Modernize the LOAD_ATTR family (python#101488)
  pythongh-101498 : Fix asyncio.Timeout example in docs (python#101499)
  pythongh-101454: fix documentation for END_ASYNC_FOR (python#101455)
  pythongh-101277: Isolate itertools, add group and _grouper types to module state (python#101302)
  pythongh-101317: Add `ssl_shutdown_timeout` parameter for `asyncio.StreamWriter.start_tls` (python#101335)
  datetime.rst: fix combine() signature (python#101490)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.11 only security fixes 3.12 bugs and security fixes docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-101454: fix documentation for END_ASYNC_FOR iritkatriel/cpython
1 participant
@iritkatriel