Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ci.yml #407

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Improve ci.yml #407

merged 1 commit into from
Mar 25, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 22, 2022

Changes:

  1. Updates codecov version to the latest one
  2. Fixes cache key, it should include both txt files ('pyproject.toml' does not exist) and python version

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #407 (de8ab61) into master (bbc8f7e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #407   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1298      1298           
=========================================
  Hits          1298      1298           

@sobolevn sobolevn requested a review from Mariatta February 22, 2022 16:05
@hugovk
Copy link
Member

hugovk commented Mar 20, 2022

We can actually remove actions/cache as a separate run and use the built-in pip caching form actions/setup-python:

https://github.com/actions/setup-python#caching-packages-dependencies

Something like this:

- uses: actions/setup-python@v3
  with:
    python-version: ${{ matrix.python-version }}
    cache: 'pip'
    cache-dependency-path: |
      dev-requirements.txt
      requirements.txt

Edit: this stuff included in #416:

This caching of course only applies to actions/setup-python, and not deadsnakes/action used for the *-dev versions. But:

  1. we're not actually testing any -dev versions

  2. if we do want to test -dev, actions/setup-python now also supplies them. One important difference: actions/setup-python supplies the latest alpha/beta/RC, whereas deadsnakes/action gives a nightly build. Usually the latest alpha/beta/RC is enough? If so we can remove:

      - uses: deadsnakes/[email protected]
        if: endsWith(matrix.python-version, '-dev')
        with:
          python-version: ${{ matrix.python-version }}

Edit: this stuff included in #416:

Finally, we can update most (all?) of GitHub's own actions/* from v2 to v3.

@Mariatta Mariatta merged commit 837aacc into python:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants