-
-
Notifications
You must be signed in to change notification settings - Fork 178
Fix for #404 #460
base: master
Are you sure you want to change the base?
Fix for #404 #460
Conversation
Fixes #404 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating _FATAL_ERROR_IGNORE
worries me: I don't think I understand all consequences of this PR. Could you please elaborate more?
|
Makes sense. Would you be able to write a unittest for this? |
@asvetlov If you want this in 3.6.1 you need to add a unittest and resubmit this PR to python/cpython today. |
@1st1 ok, so 3.6.1 is going out after today? btw would it also include the latest version of zlib as well because it has updated a to version above 1.2.8 this year to fix bugs and stuff. |
Yes. Re zlib - not sure, please check on GH or bugs.python.org or python-dev mailing list. |
hmm, from the looks on http://svn.python.org/projects/external/ I only see it having zlib v1.2.3 But I could have sworn python 3.6.0 was using 1.2.8. Will look at bugs.python.org or the python-dev irc channel. |
@1st1 It looks like this repo was not marked as |
@asvetlov are you going to resubmit this PR to python/cpython ? I hope it's not abandoned. |
Don't pass ssl certivicate error to loop.call_exception_handler()
Handle ssl.CertificateError only because ssl.SSLError may be raised not only on connection establishment.
@1st1 please take a look