Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Repeat with line 71, read data stream repeatedly #1564

Closed
wants to merge 1 commit into from

Conversation

nanmuyao
Copy link

Repeat with line 71, read data stream repeatedly

@aaugustin
Copy link
Member

This change is incorrect. I expect the test suite to fail and tell you why it's incorrect.

@aaugustin aaugustin closed this Dec 14, 2024
@nanmuyao
Copy link
Author

nanmuyao commented Dec 14, 2024

This change is incorrect. I expect the test suite to fail and tell you why it's incorrect.

sorry,my fault,read(2) and next read(2) is diffrent position data, i'd like to know how tu run test suit,

  1. github Checks, it'll running all the time ?now it running 3h+
21734181048_ pic
  1. run tox on my mac, it‘ll stuck
(.venv) ➜  my-websockets git:(main) ✗ tox -v
py39: find interpreter for spec PythonSpec(major=3, minor=9)
py39: proposed PythonInfo(spec=CPython3.9.6.final.0-64, system=/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/bin/python3.9, exe=/Users/hanzhiqiang/Documents/my-websockets/.venv/bin/python, platform=darwin, version='3.9.6 (default, Oct  4 2024, 08:01:32) \n[Clang 16.0.0 (clang-1600.0.26.4)]', encoding_fs_io=utf-8-utf-8)
.pkg: find interpreter for spec PythonSpec(path=/Users/hanzhiqiang/Documents/my-websockets/.venv/bin/python)
.pkg: proposed PythonInfo(spec=CPython3.9.6.final.0-64, system=/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/bin/python3.9, exe=/Users/hanzhiqiang/Documents/my-websockets/.venv/bin/python, platform=darwin, version='3.9.6 (default, Oct  4 2024, 08:01:32) \n[Clang 16.0.0 (clang-1600.0.26.4)]', encoding_fs_io=utf-8-utf-8)
.pkg: _optional_hooks> python /Users/hanzhiqiang/Documents/my-websockets/.venv/lib/python3.9/site-packages/pyproject_api/_backend.py True setuptools.build_meta
.pkg: exit None (0.17 seconds) /Users/hanzhiqiang/Documents/my-websockets> python /Users/hanzhiqiang/Documents/my-websockets/.venv/lib/python3.9/site-packages/pyproject_api/_backend.py True setuptools.build_meta pid=21606
.pkg: get_requires_for_build_sdist> python /Users/hanzhiqiang/Documents/my-websockets/.venv/lib/python3.9/site-packages/pyproject_api/_backend.py True setuptools.build_meta
.pkg: exit None (0.30 seconds) /Users/hanzhiqiang/Documents/my-websockets> python /Users/hanzhiqiang/Documents/my-websockets/.venv/lib/python3.9/site-packages/pyproject_api/_backend.py True setuptools.build_meta pid=21607
.pkg: build_sdist> python /Users/hanzhiqiang/Documents/my-websockets/.venv/lib/python3.9/site-packages/pyproject_api/_backend.py True setuptools.build_meta
.pkg: exit None (0.53 seconds) /Users/hanzhiqiang/Documents/my-websockets> python /Users/hanzhiqiang/Documents/my-websockets/.venv/lib/python3.9/site-packages/pyproject_api/_backend.py True setuptools.build_meta pid=21612
py39: install_package> python -I -m pip install --force-reinstall --no-deps /Users/hanzhiqiang/Documents/my-websockets/.tox/.tmp/package/2/websockets-14.2.dev0+gunknown.tar.gz
py39: exit 0 (4.86 seconds) /Users/hanzhiqiang/Documents/my-websockets> python -I -m pip install --force-reinstall --no-deps /Users/hanzhiqiang/Documents/my-websockets/.tox/.tmp/package/2/websockets-14.2.dev0+gunknown.tar.gz pid=21627
py39: commands[0]> python -W error::DeprecationWarning -W error::PendingDeprecationWarning -m unittest
................F..

@aaugustin
Copy link
Member

Looks like this error causes the test suite to hang rather than fail 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants