add @background_with_channel
#3197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakkdl
commented
Jan 31, 2025
Comment on lines
+474
to
+487
| async def test_background_with_channel_waitwhat() -> None: | ||
| @background_with_channel() | ||
| async def agen() -> AsyncGenerator[int]: | ||
| yield 1 | ||
| # this exception sometimes disappear, and I don't know why | ||
| # gc? trio randomness? | ||
| # idk if it's gonna show up in CI, but I have like a 50% shot of failing | ||
| # when running the test case by itself | ||
| raise ValueError("oae") | ||
|
|
||
| with RaisesGroup(ValueError): | ||
| async with agen() as recv_chan: | ||
| async for x in recv_chan: | ||
| assert x == 1 |
There was a problem hiding this comment.
this is the cause of the CI fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just shepherding @Zac-HD's implementation from #638 (comment)
I don't understand all the details of it, esp some of the code paths I'm completely failing how to cover, so gonna need some help. And I'm getting an exception that sometimes disappear.. which seems bad?
Feel free to add code suggestions and/or commit directly to the branch.
I don't know if this fully resolves #638, or if there's docs and/or other stuff that should be added.
I will make https://flake8-async.readthedocs.io/en/latest/rules.html#async900 suggest using this, and perhaps make it enabled by default, once released.