Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type RaisesGroup properly #3141

Merged
merged 15 commits into from
Nov 27, 2024
Merged

Type RaisesGroup properly #3141

merged 15 commits into from
Nov 27, 2024

Commits on Nov 19, 2024

  1. Clean things up a bit first

    @A5rocks
    A5rocks committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    63698fb View commit details
    Browse the repository at this point in the history

  2. Fix consequences of not subclassing BaseExceptionGroup

    @A5rocks
    A5rocks committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    bb53208 View commit details
    Browse the repository at this point in the history

  3. Make mypy pass

    @A5rocks
    A5rocks committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    9cbf18d View commit details
    Browse the repository at this point in the history

  4. Narrow BaseExceptionGroup to ExceptionGroup if there's no BaseExceptions

    @A5rocks
    A5rocks committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    2c3173f View commit details
    Browse the repository at this point in the history

  5. Clean up

    @A5rocks
    A5rocks committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    cb9e6e2 View commit details
    Browse the repository at this point in the history

  6. Finalize things

    @A5rocks
    A5rocks committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    2c2b100 View commit details
    Browse the repository at this point in the history

  7. Make mypy OK with self.check usage

    @A5rocks
    A5rocks committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0e7d845 View commit details
    Browse the repository at this point in the history

  8. Try removing Sphinx workarounds, just in case 

    (I cannot test this locally because our Sphinx builds fail on Windows)
    @A5rocks
    A5rocks committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d53b0cc View commit details
    Browse the repository at this point in the history

  9. Address PR review 

    Co-authored-by: John Litborn <[email protected]>
    @A5rocks @jakkdl
    A5rocks and jakkdl committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a671dab View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2024

  1. PR feedback

    @A5rocks
    A5rocks committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    ed8d8b1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into raisesgroup-typing

    @A5rocks
    A5rocks authored Nov 24, 2024
    Configuration menu
    Copy the full SHA
    a6bcda1 View commit details
    Browse the repository at this point in the history

  3. Update for latest ruff rules

    @A5rocks
    A5rocks committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    8a636ef View commit details
    Browse the repository at this point in the history

  4. Handle pyright's differences

    @A5rocks
    A5rocks committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    4a79ac4 View commit details
    Browse the repository at this point in the history

  5. Add a link to track the mypy bug

    @A5rocks
    A5rocks committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    5a96b1a View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. PR review

    @A5rocks
    A5rocks committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    1bb15c0 View commit details
    Browse the repository at this point in the history