Make pyright recognize open_memory_channel as generic
#2874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit.ci autofix |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2874 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 115 115
Lines 17611 17611
Branches 3149 3149
=======================================
Hits 17468 17468
Misses 99 99
Partials 44 44
|
|
Let's hold 0.23.2 until #2734 is finished, to make sure we haven't missed any similar issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2873
Minimal changes required. It's also possible to reorganize code but meh.
Not sure if there's a way to scan
triofor other occurances of this... other than runningpyrightover it and fixing everything which I absolutely do not want to do. 2 type checkers is 1 too many!