Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typecheck failures in master #2777

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Conversation

TeamSpen210
Copy link
Contributor

This fixes the issues that were causing mypy to fail, extracted from #2773.

@TeamSpen210 TeamSpen210 added the typing Adding static types to trio's interface label Aug 26, 2023
@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #2777 (a841103) into master (0c108f9) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2777    +/-   ##
========================================
  Coverage   98.94%   98.94%            
========================================
  Files         113      113            
  Lines       16843    16943   +100     
  Branches     3036     3066    +30     
========================================
+ Hits        16665    16765   +100     
  Misses        123      123            
  Partials       55       55            

see 2 files with indirect coverage changes

Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially the same types I came up with independently for #2761 so looks good.

trio/_tests/check_type_completeness.py Outdated Show resolved Hide resolved
trio/_tests/check_type_completeness.py Outdated Show resolved Hide resolved
@jakkdl jakkdl merged commit 7f78303 into python-trio:master Aug 28, 2023
26 of 27 checks passed
@TeamSpen210 TeamSpen210 deleted the fix-failures branch August 28, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typing Adding static types to trio's interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants