Fix new JSONField validation. #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Description:** Our setup (Django==3.2.25) has an automatic call to full_clean() on all Models in a pre-save signal. After upgrading from 4.0.0 to 5.4.1 all our new Django Admins lost the ability to login. We tracked it down to these calls here https://github.com/python-social-auth/social-app-django/blob/5.4.1/social_django/storage.py#L147, creation fails because `extra_data` is not passed to `create`, but the field is required not null and not blank and not empty dictionary. Making it blank-able and null-able will solve the issue. **TestPlan:** Before the fix (any version between 5.3.0 and 5.4.1): ``` UserSocialAuth.objects.create(user=User.objects.first(), uid=1, provider="test") [...] ValidationError: {'extra_data': ['This field cannot be blank.']} ``` After the fix: the UserSocialAuth instance should be created correctly.
for more information, see https://pre-commit.ci
nijel
reviewed
May 29, 2024
Co-authored-by: Michal Čihař <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #580 +/- ##
==========================================
- Coverage 91.72% 91.56% -0.17%
==========================================
Files 39 40 +1
Lines 1172 1185 +13
Branches 144 147 +3
==========================================
+ Hits 1075 1085 +10
- Misses 72 73 +1
- Partials 25 27 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Merged, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Our setup (Django==3.2.25) has an automatic call to full_clean() on all Models in a pre-save signal.
After upgrading from 4.0.0 to 5.4.1 all our new Django Admins lost the ability to login.
We tracked it down to these calls here https://github.com/python-social-auth/social-app-django/blob/5.4.1/social_django/storage.py#L147, creation fails because
extra_datais not passed tocreate, but the field is required not null and not blank and not empty dictionary.Making it blank-able and null-able will solve the issue.
TestPlan:
Before the fix (any version between 5.3.0 and 5.4.1):
After the fix: the UserSocialAuth instance should be created correctly.