Fix extension root patching #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoors
approved these changes
Jul 29, 2025
patching extension roots was raising 'invalidPath' errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patching operations add and replace, when
pathwas an extension schema exactly, were raisinginvalidPatherrors, now they are possible.Patching delete operation was raising an
invalidPatherror, and now it raises anoTarget. According to the RFCinvalidPathis for invalid or malformed attributes whilenoTargetis for attribute [...] attribute that could not be operated on. ActuallynoTargetis only illustrated with unmatching filters, but I suppose this is OK here. Any opinions?Anyway, according to RFCs extensions can be optional or required, and this is not handled by scim2-models at the moment, so I suppose the behavior should be different for required extensions (i.e. return some kind of error) and for optional ones (i.e. succeed). python-scim/scim2-models#105