Remove dependency on build package being installed while running tests
#755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @kloczek @musicinmybrain @jgarte this PR might be of interest to you, let me know if this fixes the issues you were having with running tests in your configurations |
lieryan
changed the title
build during testbuild package being installed while running tests
This seems more reliable than sys.prefix on certain virtualenv configuration.
lieryan
force-pushed
the
remove-build-during-test
branch
from
22ba63d
to
4deab03
Compare
This was referenced Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have some tests that depends on
buildpackage being installed during test. This is causing some issues with some people running tests and packaging rope.Fixes #478, #727, #749.
Checklist (delete if not relevant):