Implement JSON DataFile serialization #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's easier to parse this because `json.loads(object_hook)` exists, but there's no `json.loads(array_hook)`
Now that tuple encoding is no longer being overloaded with list, this can become much simpler.
9 tasks
Parenthesised context manager isn't supported until Python 3.10 and up (and unofficially, since Python 3.9).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make ScopeInfo JSON-serializable: there are some data here that are python class instances, but they really doesn't need to be, we can just
__getstate__()/__setstate__()them instead when de/serializing.This PR doesn't implement reading from the JSON files yet. Rope is currently still only reading out from the existing pickle files.
Part of the series: #605
Checklist (delete if not relevant):