Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RuntimeWarning: Unknown node type <MatchMapping> #522

Closed
edreamleo opened this issue Nov 18, 2022 · 2 comments · Fixed by #525
Closed

RuntimeWarning: Unknown node type <MatchMapping> #522

edreamleo opened this issue Nov 18, 2022 · 2 comments · Fixed by #525
Assignees
@lieryan
Labels
bug Unexpected or incorrect user-visible behavior
Milestone
1.5.0

Comments

@edreamleo
Copy link
Contributor

Describe the bug

Running all tests with pytest -v -W ignore::DeprecationWarning yields:

ropetest/refactor/extracttest.py::ExtractMethodTest::test_extract_method_containing_structural_pattern_match_3
  C:\Repos\rope\rope\refactor\patchedast.py:93: RuntimeWarning: Unknown node type <MatchMapping>; please report!

To Reproduce

Other information

  • Python version: Python 3.10.5
    (tags/v3.10.5:f377153, Jun 6 2022, 16:14:13) [MSC v.1929 64 bit (AMD64)] on win32
  • pytest version: pytest 7.1.3
  • Rope version: 5f8bd4a
  • Text editor/IDE and version (not used in test): Leo 6.7.2-devel
@edreamleo edreamleo added the bug Unexpected or incorrect user-visible behavior label Nov 18, 2022
lieryan added a commit that referenced this issue Nov 21, 2022
@lieryan
Fix #522. Implement patchedast parsing of MatchMapping
8a092db 
Somehow, this was missed back when the rest of `match` statement was
implemented.
@lieryan lieryan mentioned this issue Nov 21, 2022
Merged
2 tasks
@lieryan lieryan self-assigned this Nov 21, 2022
lieryan added a commit that referenced this issue Nov 21, 2022
@lieryan
Merge pull request #525 from python-rope/lieryan-522-implement-match-…
46bf39c 
…mapping

Fix #522. Implement patchedast parsing of MatchMapping
@lieryan
Copy link
Member

lieryan commented Nov 21, 2022

Thanks for reporting this issue. This should be fixed now in master and should be included for the upcoming 1.5.0 release.

@lieryan lieryan added this to the 1.5.0 milestone Nov 21, 2022
@edreamleo
Copy link
Contributor Author

@lieryan You're welcome :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lieryan lieryan

Labels
bug Unexpected or incorrect user-visible behavior
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

Fix #522. Implement patchedast parsing of MatchMapping python-rope/rope
2 participants
@edreamleo @lieryan