Handle generic iterables #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This targets issue python-rapidjson#84, automatically dumping generic iterables as arrays. To overcome the inefficiency in handling generic iterables with the previous stack-based implementation of the dumps_internal() function, this replaces it with plain recursion so there's no need to build a temporary list consuming the iterable and then pushing each item in reverse order.
|
Sorry @kenrobbins, hit the wrong link... :) |
Drop parametric data from the pytest-benchmark JSON output, to keep its size reasonable. See ionelmc/pytest-benchmark#96.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This targets issue #84, automatically dumping generic iterables as arrays.
To overcome the inefficiency in handling generic iterables with the previous stack-based
implementation of the dumps_internal() function, this replaces it with plain recursion so
there's no need to build a temporary list consuming the iterable and then pushing each
item in reverse order.