Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W.I.P.] Update benchmarks: Drop ujson, add hyperjson, add orjson (issue #130) #131

Closed

Conversation

hartwork
Copy link

@hartwork hartwork commented Feb 23, 2020

For #130

Should not be merged right now because:

@lelit what do you think?

lelit added a commit that referenced this pull request Feb 29, 2020
This addresses issue #130. Thanks to Sebastian Pipping for initial implementation (see
PR #131) and research.
@lelit
Copy link
Contributor

lelit commented Feb 29, 2020

Hi!

I tried to replicate the problem with ujson, but it works for me (Debian sid here), either with Python 3.7 or Python 3.8... I thus opted to keep it around.

I also did not notice the difference between RJ and standard library json.

OOC, on which OS/hardware did you run the benchmarks?

Anyway, thanks a lot for your initial implementation and research.

@hartwork
Copy link
Author

hartwork commented Feb 29, 2020

I tried to replicate the problem with ujson, but it works for me (Debian sid here), either with Python 3.7 or Python 3.8... I thus opted to keep it around.

The underlying link issue was fixed upstream now at ultrajson/ultrajson#312 . I'm not sure why import does not fail with a link error for you, too.

I expect ujson 2.0.0 to perform rather differently than 1.35 so it might be worth benchmarking against (both ujson 1.35 and) 2.0.0 later.

I also did not notice the difference between RJ and standard library json.

OOC, on which OS/hardware did you run the benchmarks?

16 GB RAM, Intel(R) Core(TM) i5-2520M CPU @ 2.50GHz, 2 cores, 2 threads per core, Gentoo Linux

Closing PR becauce of:

@hartwork hartwork closed this Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants