Enable the possibility to not bundle rapidjson with the package? #60
Comments
|
Can you give some more information on this? Is it just some kind of option so that you can build python-rapidjson using a different path where the compiler search for the rapidjson includes, or what? |
|
Yes exactly. For example, the pyzmq wheel from pypi bundles libzmq. The one from conda uses the libzmq from conda which is its own package. |
lelit
added a commit
that referenced
this issue
Jan 26, 2017
This allows to use a local copy of the RapidJSON include files, without the need of cloning its repository into the ./rapidjson submodule. This fixes issue #60.
|
Sylvain, does this fulfill your needs? |
|
@lelit thanks! I will try this for the conda-forge recipe and get back to you. |
|
Just curious, did that help? |
|
The proposed change is included in version 0.0.9, please reopen the issue if that's not enough. |
|
THanks @lelit and sorry for the late reply. I am updating the conda recipe to 0.10.0 and testing the functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Both rapidjson and python-rapidjson have been bundled for conda-forge,
However, the latter makes use of the
rapidjsonsubmodule.It would probably make sense for the
setup.pyto handle the case where an installation prefix for rapidjson is provided instead of a submodule.For reference, such a
setup.pyhas been done forpyzmqwhich can either bundle zeromq or not.The text was updated successfully, but these errors were encountered: